diff options
author | Geoff Thorpe <geoff@openssl.org> | 2001-08-12 16:52:00 +0000 |
---|---|---|
committer | Geoff Thorpe <geoff@openssl.org> | 2001-08-12 16:52:00 +0000 |
commit | b7727ee616a3351a001497dda077ec63330861db (patch) | |
tree | cfb5ada448b2a405e2b7b3967a48ba61f690d9aa /crypto/ui | |
parent | f0446ca8d746ff138a892588e33597411f59f5fa (diff) |
The indexes returned by ***_get_ex_new_index() functions are used when
setting stack (actually, array) values in ex_data. So only increment the
global counters if the underlying CRYPTO_get_ex_new_index() call succeeds.
This change doesn't make "ex_data" right (see the comment at the head of
ex_data.c to know why), but at least makes the source code marginally less
frustrating.
Diffstat (limited to 'crypto/ui')
-rw-r--r-- | crypto/ui/ui_lib.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/crypto/ui/ui_lib.c b/crypto/ui/ui_lib.c index 00abeb0e55..c526426f8b 100644 --- a/crypto/ui/ui_lib.c +++ b/crypto/ui/ui_lib.c @@ -574,9 +574,10 @@ int UI_ctrl(UI *ui, int cmd, long i, void *p, void (*f)()) int UI_get_ex_new_index(long argl, void *argp, CRYPTO_EX_new *new_func, CRYPTO_EX_dup *dup_func, CRYPTO_EX_free *free_func) { - ui_meth_num++; - return(CRYPTO_get_ex_new_index(ui_meth_num-1, - &ui_meth,argl,argp,new_func,dup_func,free_func)); + if(CRYPTO_get_ex_new_index(ui_meth_num, &ui_meth, argl, argp, + new_func, dup_func, free_func) < 0) + return -1; + return (ui_meth_num++); } int UI_set_ex_data(UI *r, int idx, void *arg) |