diff options
author | David Benjamin <davidben@google.com> | 2019-07-23 14:14:48 -0400 |
---|---|---|
committer | David Benjamin <davidben@google.com> | 2019-07-25 16:08:27 -0400 |
commit | 166c0b98fd6e8b1bb341397642527a9396468f6c (patch) | |
tree | 5476bac297dbc26963e5ce4e0d614bfe6e0abd85 /crypto/provider.c | |
parent | 8ccf2ffbd6a98d3750b715787c80d5d2b76d054b (diff) |
Don't generate an unnecessary Diffie-Hellman key in TLS 1.3 clients.
tls_parse_stoc_key_share was generating a new EVP_PKEY public/private
keypair and then overrides it with the server public key, so the
generation was a waste anyway. Instead, it should create a
parameters-only EVP_PKEY.
(This is a consequence of OpenSSL using the same type for empty key,
empty key with key type, empty key with key type + parameters, public
key, and private key. As a result, it's easy to mistakenly mix such
things up, as happened here.)
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/9445)
Diffstat (limited to 'crypto/provider.c')
0 files changed, 0 insertions, 0 deletions