diff options
| author | Matt Caswell <matt@openssl.org> | 2016-04-25 17:06:56 +0100 |
|---|---|---|
| committer | Matt Caswell <matt@openssl.org> | 2016-06-27 15:00:08 +0100 |
| commit | ad64a69e02f7dda422d0f4f53dce7b1278715380 (patch) | |
| tree | 5c76fd6da6b731a05cbd8559db71e8c821b44f36 /crypto/pkcs12 | |
| parent | f3dbce6634dee43dcb0243544db05e101104fe6b (diff) | |
Change usage of RAND_pseudo_bytes to RAND_bytes
RAND_pseudo_bytes() allows random data to be returned even in low entropy
conditions. Sometimes this is ok. Many times it is not. For the avoidance
of any doubt, replace existing usage of RAND_pseudo_bytes() with
RAND_bytes().
Reviewed-by: Rich Salz <rsalz@openssl.org>
Diffstat (limited to 'crypto/pkcs12')
| -rw-r--r-- | crypto/pkcs12/p12_mutl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/pkcs12/p12_mutl.c b/crypto/pkcs12/p12_mutl.c index a9277827ff..cbf34da05a 100644 --- a/crypto/pkcs12/p12_mutl.c +++ b/crypto/pkcs12/p12_mutl.c @@ -179,7 +179,7 @@ int PKCS12_setup_mac(PKCS12 *p12, int iter, unsigned char *salt, int saltlen, } p12->mac->salt->length = saltlen; if (!salt) { - if (RAND_pseudo_bytes(p12->mac->salt->data, saltlen) < 0) + if (RAND_bytes(p12->mac->salt->data, saltlen) <= 0) return 0; } else memcpy(p12->mac->salt->data, salt, saltlen); |