diff options
| author | Benjamin Kaduk <bkaduk@akamai.com> | 2017-06-26 12:05:09 -0500 |
|---|---|---|
| committer | Benjamin Kaduk <kaduk@mit.edu> | 2017-06-27 10:49:53 -0500 |
| commit | c91ec013654e97ca1754db26bd2da62c8bbf7b47 (patch) | |
| tree | 417c4ea3ca0b9845d400c9cd634be57c96d45e30 /crypto/ocsp | |
| parent | 0ffdaebf9a327f3b356df1cf72d74dd15ead7d13 (diff) | |
Fix return-value checks in OCSP_resp_get1_id()
Commit db17e43d882ecde217e1dce4a2b8c76c3ed134bf added the function
but would improperly report success if the underlying dup operation
failed.
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3775)
Diffstat (limited to 'crypto/ocsp')
| -rw-r--r-- | crypto/ocsp/ocsp_cl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/ocsp/ocsp_cl.c b/crypto/ocsp/ocsp_cl.c index 118b66a2f5..f6101e1532 100644 --- a/crypto/ocsp/ocsp_cl.c +++ b/crypto/ocsp/ocsp_cl.c @@ -230,7 +230,7 @@ int OCSP_resp_get1_id(const OCSP_BASICRESP *bs, } else { return 0; } - if (pname == NULL && pid == NULL) + if (*pname == NULL && *pid == NULL) return 0; return 1; } |