diff options
| author | Benjamin Kaduk <bkaduk@akamai.com> | 2017-04-14 11:53:04 -0500 |
|---|---|---|
| committer | Rich Salz <rsalz@openssl.org> | 2017-06-20 13:35:33 -0400 |
| commit | bd97dde41e96193aa076260fb0057e9ce0f6861b (patch) | |
| tree | 10aaf85ec777ee5eeb31bfe51bcf1aa63a46c6f5 /crypto/o_str.c | |
| parent | 725f121dcfc31d016fa23bfffde1b6342659949e (diff) | |
Address some -Wold-style-declaration warnings
gcc's -Wextra pulls in -Wold-style-declaration, which triggers when a
declaration has a storage-class specifier as a non-initial qualifier.
The ISO C formal grammar requires the storage-class to be the first
component of the declaration, if present.
Seeint as the register storage-class specifier does not really have any effect
anymore with modern compilers, remove it entirely while we're here, instead of
fixing up the order.
Interestingly, the gcc devteam warnings do not pull in -Wextra, though
the clang ones do.
[extended tests]
Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3239)
(cherry picked from commit f44903a428cc63ce88bfba26e8e4e2e9b21f058d)
Diffstat (limited to 'crypto/o_str.c')
| -rw-r--r-- | crypto/o_str.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/o_str.c b/crypto/o_str.c index d8516c27bb..528655aa8c 100644 --- a/crypto/o_str.c +++ b/crypto/o_str.c @@ -193,7 +193,7 @@ unsigned char *OPENSSL_hexstr2buf(const char *str, long *len) */ char *OPENSSL_buf2hexstr(const unsigned char *buffer, long len) { - const static char hexdig[] = "0123456789ABCDEF"; + static const char hexdig[] = "0123456789ABCDEF"; char *tmp, *q; const unsigned char *p; int i; |