summaryrefslogtreecommitdiffstats
path: root/crypto/modes
diff options
context:
space:
mode:
authorChristoph Müllner <christoph.muellner@vrull.eu>2023-01-17 19:31:58 +0100
committerPauli <pauli@openssl.org>2023-03-16 13:12:19 +1100
commit86c69fe84118f0dca656d9bfc1131052e2a8e9b8 (patch)
treee753c237e45ffaa2e24f7a4e8877b51fd9120a18 /crypto/modes
parent04af51c276e7d785a194eb9ed199abf250c5b3b6 (diff)
riscv: Clean up extension test macros
In RISC-V we have multiple extensions, that can be used to accelerate processing. The known extensions are defined in riscv_arch.def. From that file test functions of the following form are generated: RISCV_HAS_$ext(). In recent commits new ways to define the availability of these test macros have been defined. E.g.: #define RV32I_ZKND_ZKNE_CAPABLE \ (RISCV_HAS_ZKND() && RISCV_HAS_ZKNE()) [...] #define RV64I_ZKND_ZKNE_CAPABLE \ (RISCV_HAS_ZKND() && RISCV_HAS_ZKNE()) This leaves us with two different APIs to test capabilities. Further, creating the same macros for RV32 and RV64 results in duplicated code (see example above). This inconsistent situation makes it hard to integrate further code. So let's clean this up with the following steps: * Replace RV32I_* and RV64I_* macros by RICSV_HAS_* macros * Move all test macros into riscv_arch.h * Use "AND" and "OR" to combine tests with more than one extension * Rename include files for accelerated processing (remove extension postfix). We end up with compile time tests for RV32/RV64 and run-time tests for available extensions. Adding new routines (e.g. for vector crypto instructions) should be straightforward. Testing showed no regressions. Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/20078)
Diffstat (limited to 'crypto/modes')
-rw-r--r--crypto/modes/gcm128.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/modes/gcm128.c b/crypto/modes/gcm128.c
index 0b31e671f0..a49798b7f4 100644
--- a/crypto/modes/gcm128.c
+++ b/crypto/modes/gcm128.c
@@ -502,7 +502,7 @@ static void gcm_get_funcs(struct gcm_funcs_st *ctx)
#elif defined(GHASH_ASM_RISCV) && __riscv_xlen == 64
/* RISCV defaults; gmult already set above */
ctx->ghash = NULL;
- if (RISCV_HAS_ZBB() && RISCV_HAS_ZBC()) {
+ if (RISCV_HAS_ZBB_AND_ZBC()) {
ctx->ginit = gcm_init_clmul_rv64i_zbb_zbc;
ctx->gmult = gcm_gmult_clmul_rv64i_zbb_zbc;
}