diff options
author | Dr. David von Oheimb <David.von.Oheimb@siemens.com> | 2021-11-26 16:46:13 +0100 |
---|---|---|
committer | Dr. David von Oheimb <dev@ddvo.net> | 2022-01-04 15:06:18 +0100 |
commit | 46ee414f64a846a6a7606b1fba47a084dea172eb (patch) | |
tree | 8836f7516eb3f39476002b821f47056a49a3c920 /crypto/http/http_client.c | |
parent | d65b3db98022257cbf83d7d164bc0a8a9b92c101 (diff) |
HTTP client: Work around HTTPS proxy use bug due to callback design flaw
See discussion in #17088, where the real solution was postponed to 4.0.
This preliminarily fixes the issue that the HTTP(S) proxy environment vars
were neglected when determining whether a proxy should be used for HTTPS.
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17310)
(cherry picked from commit 068549f8db6d792a88bb888118001c4582f79074)
Diffstat (limited to 'crypto/http/http_client.c')
-rw-r--r-- | crypto/http/http_client.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto/http/http_client.c b/crypto/http/http_client.c index c80d4fe519..4e34d0d3d1 100644 --- a/crypto/http/http_client.c +++ b/crypto/http/http_client.c @@ -947,6 +947,7 @@ OSSL_HTTP_REQ_CTX *OSSL_HTTP_open(const char *server, const char *port, } /* now overall_timeout is guaranteed to be >= 0 */ + /* adapt in order to fix callback design flaw, see #17088 */ /* callback can be used to wrap or prepend TLS session */ if (bio_update_fn != NULL) { BIO *orig_bio = cbio; |