diff options
| author | Richard Levitte <levitte@openssl.org> | 2021-04-12 12:11:07 +0200 |
|---|---|---|
| committer | Richard Levitte <levitte@openssl.org> | 2021-04-21 10:53:03 +0200 |
| commit | f99659535d180f15cd19c63cb53392c256e35534 (patch) | |
| tree | 5e435ea7e73a4e4421b07b93e9635380499e31fd /crypto/err | |
| parent | a2502862f679c82b794869ac88ed0d8ca7bc291c (diff) | |
ENCODER & DECODER: Allow decoder implementations to specify "carry on"
So far, decoder implementations would return true (1) for a successful
decode all the way, including what the callback it called returned,
and false (0) in all other cases.
This construction didn't allow to stop to decoding process on fatal
errors, nor to choose what to report in the provider code.
This is now changed so that decoders implementations are made to
return false only on errors that should stop the decoding process from
carrying on with other implementations, and return true for all other
cases, even if that didn't result in a constructed object (EVP_PKEY
for example), essentially making it OK to return "empty handed".
The success of the decoding process is now all about successfully
constructing the final object, rather than about the return value of
the decoding chain. If no construction is attempted, the central
decoding processing code concludes that whatever the input consisted
of, it's not supported by the available decoder implementations.
Fixes #14423
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14834)
Diffstat (limited to 'crypto/err')
| -rw-r--r-- | crypto/err/openssl.txt | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto/err/openssl.txt b/crypto/err/openssl.txt index eed0b71ada..81f9f1ef49 100644 --- a/crypto/err/openssl.txt +++ b/crypto/err/openssl.txt @@ -811,6 +811,7 @@ OCSP_R_STATUS_TOO_OLD:127:status too old OCSP_R_UNKNOWN_MESSAGE_DIGEST:119:unknown message digest OCSP_R_UNKNOWN_NID:120:unknown nid OCSP_R_UNSUPPORTED_REQUESTORNAME_TYPE:129:unsupported requestorname type +OSSL_DECODER_R_COULD_NOT_DECODE_OBJECT:101:could not decode object OSSL_DECODER_R_MISSING_GET_PARAMS:100:missing get params OSSL_ENCODER_R_ENCODER_NOT_FOUND:101:encoder not found OSSL_ENCODER_R_INCORRECT_PROPERTY_QUERY:100:incorrect property query |