diff options
| author | FdaSilvaYY <fdasilvayy@gmail.com> | 2017-12-08 10:49:41 -0500 |
|---|---|---|
| committer | Rich Salz <rsalz@openssl.org> | 2017-12-08 10:49:41 -0500 |
| commit | a0fda2cf2dac8bc0d309261b3aaf4027a188b08c (patch) | |
| tree | cdb682c910f5ae4825b1e3686facb1073f35c56d /crypto/err | |
| parent | cef115ff0ca4255d3decc1dda87c5418a961fd2c (diff) | |
Address some code-analysis issues.
Expression '...' is always true.
The 'b->init' variable is assigned values twice successively
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4753)
Diffstat (limited to 'crypto/err')
| -rw-r--r-- | crypto/err/err.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/crypto/err/err.c b/crypto/err/err.c index 75dc715deb..bd9e062fd1 100644 --- a/crypto/err/err.c +++ b/crypto/err/err.c @@ -502,15 +502,13 @@ static unsigned long get_error_values(int inc, int top, const char **file, es->err_buffer[i] = 0; } - if ((file != NULL) && (line != NULL)) { + if (file != NULL && line != NULL) { if (es->err_file[i] == NULL) { *file = "NA"; - if (line != NULL) - *line = 0; + *line = 0; } else { *file = es->err_file[i]; - if (line != NULL) - *line = es->err_line[i]; + *line = es->err_line[i]; } } |