summaryrefslogtreecommitdiffstats
path: root/crypto/ec
diff options
context:
space:
mode:
authorMatt Caswell <matt@openssl.org>2023-08-30 15:48:02 +0100
committerHugo Landau <hlandau@openssl.org>2023-09-01 10:08:20 +0100
commit3961991593f788b3efb2a27563d358c7c58f854c (patch)
treec9dc1c9e47514ad72cd5646a1bfa4b2f401b32f8 /crypto/ec
parent50f8b936b00dc18ce1f622a7a6aa46daf03da48b (diff)
Remove a redundant point mul from ossl_ec_key_public_check()
This code was added in error and is entirely redundant. It is also an expensive operation (e.g. see #21833). Fixes #21834 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from https://github.com/openssl/openssl/pull/21902)
Diffstat (limited to 'crypto/ec')
-rw-r--r--crypto/ec/ec_key.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/crypto/ec/ec_key.c b/crypto/ec/ec_key.c
index e428b45d4a..2bf3e601f1 100644
--- a/crypto/ec/ec_key.c
+++ b/crypto/ec/ec_key.c
@@ -581,11 +581,6 @@ int ossl_ec_key_public_check(const EC_KEY *eckey, BN_CTX *ctx)
ERR_raise(ERR_LIB_EC, ERR_R_EC_LIB);
goto err;
}
- /* Perform a second check on the public key */
- if (!EC_POINT_mul(eckey->group, point, NULL, eckey->pub_key, order, ctx)) {
- ERR_raise(ERR_LIB_EC, ERR_R_EC_LIB);
- goto err;
- }
if (!EC_POINT_is_at_infinity(eckey->group, point)) {
ERR_raise(ERR_LIB_EC, EC_R_WRONG_ORDER);
goto err;