diff options
| author | Ben Kaduk <bkaduk@akamai.com> | 2015-08-28 12:41:50 -0400 |
|---|---|---|
| committer | Rich Salz <rsalz@openssl.org> | 2015-08-31 13:47:12 -0400 |
| commit | a6ce498b2a00ea7bdca0730064d7ee62b77d87cb (patch) | |
| tree | 7af16b2af034912c2990363450f9d79f4d964853 /crypto/dsa | |
| parent | d46e946d2603c64df6e1e4f9db0c70baaf1c4c03 (diff) | |
GH367 follow-up, for more clarity
Signed-off-by: Rich Salz <rsalz@akamai.com>
Reviewed-by: Emilia Käsper <emilia@openssl.org>
(cherry picked from commit 36ac7bc8a9c856bcdff6eecdaca128ccc5430a1e)
Diffstat (limited to 'crypto/dsa')
| -rw-r--r-- | crypto/dsa/dsa_gen.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c index 44c47a3f82..1f12d6b4f7 100644 --- a/crypto/dsa/dsa_gen.c +++ b/crypto/dsa/dsa_gen.c @@ -165,7 +165,7 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t qbits, if (seed_len < (size_t)qsize) return 0; if (seed_len > (size_t)qsize) { - /* Don't overflow seed local variable. */ + /* Only consume as much seed as is expected. */ seed_len = qsize; } memcpy(seed, seed_in, seed_len); @@ -192,13 +192,13 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t qbits, for (;;) { for (;;) { /* find q */ - int seed_is_random = seed_in == NULL; + int use_random_seed = (seed_in == NULL); /* step 1 */ if (!BN_GENCB_call(cb, 0, m++)) goto err; - if (seed_is_random) { + if (use_random_seed) { if (RAND_bytes(seed, qsize) <= 0) goto err; } else { @@ -230,7 +230,7 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t qbits, /* step 4 */ r = BN_is_prime_fasttest_ex(q, DSS_prime_checks, ctx, - seed_is_random, cb); + use_random_seed, cb); if (r > 0) break; if (r != 0) |