summaryrefslogtreecommitdiffstats
path: root/crypto/dsa
diff options
context:
space:
mode:
authorUlf Möller <ulf@openssl.org>2001-02-07 22:24:35 +0000
committerUlf Möller <ulf@openssl.org>2001-02-07 22:24:35 +0000
commit57e7d3ce1546fc6026ffe3f1f243c54d0bb59d3e (patch)
tree0145db13ba92d21247ffa1de25a4202603515f91 /crypto/dsa
parenta8ebe4697e99ac642fa73b20f5698091b7976f63 (diff)
Bleichenbacher's DSA attack
Diffstat (limited to 'crypto/dsa')
-rw-r--r--crypto/dsa/dsa_ossl.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/crypto/dsa/dsa_ossl.c b/crypto/dsa/dsa_ossl.c
index 4b600fa731..7304037947 100644
--- a/crypto/dsa/dsa_ossl.c
+++ b/crypto/dsa/dsa_ossl.c
@@ -180,13 +180,7 @@ static int dsa_sign_setup(DSA *dsa, BN_CTX *ctx_in, BIGNUM **kinvp, BIGNUM **rp)
kinv=NULL;
/* Get random k */
- for (;;)
- {
- if (!BN_rand(&k, BN_num_bits(dsa->q), 0, 0)) goto err;
- if (BN_cmp(&k,dsa->q) >= 0)
- BN_sub(&k,&k,dsa->q);
- if (!BN_is_zero(&k)) break;
- }
+ if (!BN_rand_range(&k, BN_value_one(), dsa->q)) goto err;
if ((dsa->method_mont_p == NULL) && (dsa->flags & DSA_FLAG_CACHE_MONT_P))
{