diff options
| author | Ben Laurie <ben@openssl.org> | 2005-04-23 06:05:24 +0000 |
|---|---|---|
| committer | Ben Laurie <ben@openssl.org> | 2005-04-23 06:05:24 +0000 |
| commit | e9ad6665a517652e8da6da5165f72c7ab8e9c34f (patch) | |
| tree | e7655ad8419cb4d4e87ecc68641618943a697e7b /crypto/dsa/dsa_ossl.c | |
| parent | b5855b2f32d7fb89937093459230b6252cdf400b (diff) | |
Add debug target, remove cast, note possible bug.
Diffstat (limited to 'crypto/dsa/dsa_ossl.c')
| -rw-r--r-- | crypto/dsa/dsa_ossl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/crypto/dsa/dsa_ossl.c b/crypto/dsa/dsa_ossl.c index a37763468a..033bf9017f 100644 --- a/crypto/dsa/dsa_ossl.c +++ b/crypto/dsa/dsa_ossl.c @@ -326,6 +326,8 @@ static int dsa_do_verify(const unsigned char *dgst, int dgst_len, DSA_SIG *sig, ret=(BN_ucmp(&u1, sig->r) == 0); err: + /* XXX: surely this is wrong - if ret is 0, it just didn't verify + there is no error in BN. Test should be ret == -1 (Ben) */ if (ret != 1) DSAerr(DSA_F_DSA_DO_VERIFY,ERR_R_BN_LIB); if (ctx != NULL) BN_CTX_free(ctx); BN_free(&u1); |