diff options
| author | Pauli <pauli@openssl.org> | 2021-05-31 14:29:33 +1000 |
|---|---|---|
| committer | Pauli <pauli@openssl.org> | 2021-06-02 16:30:15 +1000 |
| commit | 75e1191f4d1185ebf7b94e620b15a73f22af146e (patch) | |
| tree | 34c619327d59a104c23821f6a1cac029c43b1ddc /crypto/cmp/cmp_msg.c | |
| parent | 69e21cb648f140c173ba238a761ce700bef643f6 (diff) | |
cmp: remove TODOs
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15539)
Diffstat (limited to 'crypto/cmp/cmp_msg.c')
| -rw-r--r-- | crypto/cmp/cmp_msg.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/crypto/cmp/cmp_msg.c b/crypto/cmp/cmp_msg.c index 77b2175b11..b9c347afb8 100644 --- a/crypto/cmp/cmp_msg.c +++ b/crypto/cmp/cmp_msg.c @@ -399,7 +399,6 @@ OSSL_CMP_MSG *ossl_cmp_certreq_new(OSSL_CMP_CTX *ctx, int type, if (!sk_OSSL_CRMF_MSG_push(msg->body->value.ir, local_crm)) goto err; local_crm = NULL; - /* TODO: here optional 2nd certreqmsg could be pushed to the stack */ } if (!ossl_cmp_msg_protect(ctx, msg)) @@ -465,7 +464,6 @@ OSSL_CMP_MSG *ossl_cmp_certrep_new(OSSL_CMP_CTX *ctx, int bodytype, if (!sk_OSSL_CMP_CERTRESPONSE_push(repMsg->response, resp)) goto err; resp = NULL; - /* TODO: here optional 2nd certrep could be pushed to the stack */ if (bodytype == OSSL_CMP_PKIBODY_IP && caPubs != NULL && (repMsg->caPubs = X509_chain_up_ref(caPubs)) == NULL) @@ -529,11 +527,6 @@ OSSL_CMP_MSG *ossl_cmp_rr_new(OSSL_CMP_CTX *ctx) goto err; rd = NULL; - /* - * TODO: the Revocation Passphrase according to section 5.3.19.9 could be - * set here if set in ctx - */ - if (!ossl_cmp_msg_protect(ctx, msg)) goto err; @@ -749,10 +742,6 @@ int ossl_cmp_certstatus_set0_certHash(OSSL_CMP_CERTSTATUS *certStatus, return 1; } -/* - * TODO: handle potential 2nd certificate when signing and encrypting - * certificates have been requested/received - */ OSSL_CMP_MSG *ossl_cmp_certConf_new(OSSL_CMP_CTX *ctx, int fail_info, const char *text) { @@ -827,7 +816,6 @@ OSSL_CMP_MSG *ossl_cmp_pollReq_new(OSSL_CMP_CTX *ctx, int crid) if ((msg = ossl_cmp_msg_create(ctx, OSSL_CMP_PKIBODY_POLLREQ)) == NULL) goto err; - /* TODO: support multiple cert request IDs to poll */ if ((preq = OSSL_CMP_POLLREQ_new()) == NULL || !ASN1_INTEGER_set(preq->certReqId, crid) || !sk_OSSL_CMP_POLLREQ_push(msg->body->value.pollReq, preq)) |