diff options
author | Richard Levitte <levitte@openssl.org> | 2000-08-06 01:35:03 +0000 |
---|---|---|
committer | Richard Levitte <levitte@openssl.org> | 2000-08-06 01:35:03 +0000 |
commit | 5584fa1709585ee6d7e4f20551a71077f0e36699 (patch) | |
tree | e59c6ef7fd05b04fffe1e128a9fc0c03efea5354 /crypto/asn1 | |
parent | 2d978cbd30f60f9e9ddaf743d818ef66ec217f47 (diff) |
For n > 7, we might get uninitialized (unzeroed) data.
Spotted by "Kyoungho Jeon" <k.h.jeon@securesoft.co.kr>.
Diffstat (limited to 'crypto/asn1')
-rw-r--r-- | crypto/asn1/a_bitstr.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crypto/asn1/a_bitstr.c b/crypto/asn1/a_bitstr.c index c0501e1ea9..7013a407ad 100644 --- a/crypto/asn1/a_bitstr.c +++ b/crypto/asn1/a_bitstr.c @@ -236,10 +236,10 @@ int ASN1_BIT_STRING_set_bit(ASN1_BIT_STRING *a, int n, int value) else c=(unsigned char *)OPENSSL_realloc(a->data,w+1); if (c == NULL) return(0); + if (w+1-a->length > 0) memset(c+a->length, 0, w+1-a->length); a->data=c; a->length=w+1; - c[w]=0; - } + } a->data[w]=((a->data[w])&iv)|v; while ((a->length > 0) && (a->data[a->length-1] == 0)) a->length--; |