diff options
| author | xkernel <xkernel.wang@foxmail.com> | 2022-10-20 00:40:25 +0800 |
|---|---|---|
| committer | Pauli <pauli@openssl.org> | 2022-10-24 09:59:59 +1100 |
| commit | fb03e6145961005a6db011d2f36660d2eed734e2 (patch) | |
| tree | d26e249f52a27a10ba582c9bab2ab6a86b200cfc /apps | |
| parent | 5b9480fc1e814bf8fa2dce0dbbede147f04d477c (diff) | |
Checking the return of BIO_new_fp(). If it returns NULL, then it is unnecessary to build the BIO chain and better make the caller directly return NULL
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19445)
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/lib/apps.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/apps/lib/apps.c b/apps/lib/apps.c index b51afba898..3d52e030ab 100644 --- a/apps/lib/apps.c +++ b/apps/lib/apps.c @@ -2972,6 +2972,9 @@ BIO *dup_bio_out(int format) BIO_NOCLOSE | (FMT_istext(format) ? BIO_FP_TEXT : 0)); void *prefix = NULL; + if (b == NULL) + return NULL; + #ifdef OPENSSL_SYS_VMS if (FMT_istext(format)) b = BIO_push(BIO_new(BIO_f_linebuffer()), b); @@ -2992,7 +2995,7 @@ BIO *dup_bio_err(int format) BIO_NOCLOSE | (FMT_istext(format) ? BIO_FP_TEXT : 0)); #ifdef OPENSSL_SYS_VMS - if (FMT_istext(format)) + if (b != NULL && FMT_istext(format)) b = BIO_push(BIO_new(BIO_f_linebuffer()), b); #endif return b; |