summaryrefslogtreecommitdiffstats
path: root/apps
diff options
context:
space:
mode:
authorJuergen Christ <jchrist@linux.ibm.com>2022-08-29 16:54:02 +0200
committerTomas Mraz <tomas@openssl.org>2022-08-31 09:31:47 +0200
commit56233ba8574c01b3912cf662335fedaabc7faec2 (patch)
tree4c04179334fe8893ab94af1507e1fb1184cdd69d /apps
parentd9aca2dd9b56dbfa6a0566cc3ad8b7c713ac61b2 (diff)
apps/speed.c: Wait for generated children
In multi-mode, speed fork()s off several children but does not wait for them. On Linux, this leads to wrong accounting information of getrusage used by tools to extract running time and page faults. Wait for every children and check the return code and termination signal. Signed-off-by: Juergen Christ <jchrist@linux.ibm.com> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/19093)
Diffstat (limited to 'apps')
-rw-r--r--apps/speed.c16
1 files changed, 16 insertions, 0 deletions
diff --git a/apps/speed.c b/apps/speed.c
index 469a1a4441..9b9016b61c 100644
--- a/apps/speed.c
+++ b/apps/speed.c
@@ -67,6 +67,7 @@
# define HAVE_FORK 0
# else
# define HAVE_FORK 1
+# include <sys/wait.h>
# endif
#endif
@@ -3432,6 +3433,7 @@ static int do_multi(int multi, int size_num)
int n;
int fd[2];
int *fds;
+ int status;
static char sep[] = ":";
fds = app_malloc(sizeof(*fds) * multi, "fd buffer for do_multi");
@@ -3581,6 +3583,20 @@ static int do_multi(int multi, int size_num)
fclose(f);
}
OPENSSL_free(fds);
+ for (n = 0; n < multi; ++n) {
+ while (wait(&status) == -1)
+ if (errno != EINTR) {
+ BIO_printf(bio_err, "Waitng for child failed with 0x%x\n",
+ errno);
+ return 1;
+ }
+ if (WIFEXITED(status) && WEXITSTATUS(status)) {
+ BIO_printf(bio_err, "Child exited with %d\n", WEXITSTATUS(status));
+ } else if (WIFSIGNALED(status)) {
+ BIO_printf(bio_err, "Child terminated by signal %d\n",
+ WTERMSIG(status));
+ }
+ }
return 1;
}
#endif