diff options
| author | Dr. Stephen Henson <steve@openssl.org> | 2014-04-09 15:42:40 +0100 |
|---|---|---|
| committer | Dr. Stephen Henson <steve@openssl.org> | 2014-04-09 15:45:16 +0100 |
| commit | b9ce05acc42271b2b882eed481d3dcdecfa3f15e (patch) | |
| tree | 24531de040d0330d01b026a1cf5720bfb2585b3b /apps | |
| parent | 6ef9d9bacfbffa356e5a219357b1f9938fc6bb24 (diff) | |
Fix free errors in ocsp utility.
Keep copy of any host, path and port values allocated by
OCSP_parse_url and free as necessary.
(cherry picked from commit 5219d3dd350cc74498dd49daef5e6ee8c34d9857)
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/ocsp.c | 22 |
1 files changed, 16 insertions, 6 deletions
diff --git a/apps/ocsp.c b/apps/ocsp.c index ccf2f0f949..64c31826f3 100644 --- a/apps/ocsp.c +++ b/apps/ocsp.c @@ -127,6 +127,7 @@ int MAIN(int argc, char **argv) ENGINE *e = NULL; char **args; char *host = NULL, *port = NULL, *path = "/"; + char *thost = NULL, *tport = NULL, *tpath = NULL; char *reqin = NULL, *respin = NULL; char *reqout = NULL, *respout = NULL; char *signfile = NULL, *keyfile = NULL; @@ -206,6 +207,12 @@ int MAIN(int argc, char **argv) } else if (!strcmp(*args, "-url")) { + if (thost) + OPENSSL_free(thost); + if (tport) + OPENSSL_free(tport); + if (tpath) + OPENSSL_free(tpath); if (args[1]) { args++; @@ -214,6 +221,9 @@ int MAIN(int argc, char **argv) BIO_printf(bio_err, "Error parsing URL\n"); badarg = 1; } + thost = host; + tport = port; + tpath = path; } else badarg = 1; } @@ -963,12 +973,12 @@ end: sk_X509_pop_free(verify_other, X509_free); sk_CONF_VALUE_pop_free(headers, X509V3_conf_free); - if (use_ssl != -1) - { - OPENSSL_free(host); - OPENSSL_free(port); - OPENSSL_free(path); - } + if (thost) + OPENSSL_free(thost); + if (tport) + OPENSSL_free(tport); + if (tpath) + OPENSSL_free(tpath); OPENSSL_EXIT(ret); } |