diff options
| author | Rich Salz <rsalz@akamai.com> | 2015-05-01 23:10:31 -0400 |
|---|---|---|
| committer | Rich Salz <rsalz@openssl.org> | 2015-05-04 15:00:13 -0400 |
| commit | b4faea50c35d92a67d1369355b49cc3efba78406 (patch) | |
| tree | cfebea69d625f936c9fd7281f1fa3eaa2fa38834 /apps/vms_decc_init.c | |
| parent | 8920a7cd04f43b1a090d0b0a8c9e16b94c6898d4 (diff) | |
Use safer sizeof variant in malloc
For a local variable:
TYPE *p;
Allocations like this are "risky":
p = OPENSSL_malloc(sizeof(TYPE));
if the type of p changes, and the malloc call isn't updated, you
could get memory corruption. Instead do this:
p = OPENSSL_malloc(sizeof(*p));
Also fixed a few memset() calls that I noticed while doing this.
Reviewed-by: Richard Levitte <levitte@openssl.org>
Diffstat (limited to 'apps/vms_decc_init.c')
| -rw-r--r-- | apps/vms_decc_init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/vms_decc_init.c b/apps/vms_decc_init.c index 3ec7b54dcb..2b273ac5af 100644 --- a/apps/vms_decc_init.c +++ b/apps/vms_decc_init.c @@ -130,7 +130,7 @@ char **copy_argv(int *argc, char *argv[]) */ int i, count = *argc; - char **newargv = app_malloc((count + 1) * sizeof *newargv, "argv copy"); + char **newargv = app_malloc(sizeof(*newargv) * (count + 1), "argv copy"); for (i = 0; i < count; i++) newargv[i] = argv[i]; |