diff options
author | FdaSilvaYY <fdasilvayy@gmail.com> | 2018-10-07 21:47:31 +0200 |
---|---|---|
committer | Dr. Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> | 2018-12-22 18:13:53 +0100 |
commit | 9318545c2859d89c4496240649ab2f322dbd3ad8 (patch) | |
tree | 4c912b0fb856bb2aa182d94bdd55194c9ab21351 /apps/ocsp.c | |
parent | ea7d2c5808f4711edfdd25a7a4e2e39f8ee3de62 (diff) |
Coverity fix in apps/oscp
CID 1440002 (#1 of 1): Use after free (USE_AFTER_FREE)
Not a deadly error, because error was just before app exit.
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7359)
(cherry picked from commit 39fc4c17c49d248e0757bac9aa8863d205c7ad12)
Diffstat (limited to 'apps/ocsp.c')
-rw-r--r-- | apps/ocsp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/ocsp.c b/apps/ocsp.c index 7fd78624bb..de95b71ccf 100644 --- a/apps/ocsp.c +++ b/apps/ocsp.c @@ -863,6 +863,7 @@ static void killall(int ret, pid_t *kidpids) for (i = 0; i < multi; ++i) if (kidpids[i] != 0) (void)kill(kidpids[i], SIGTERM); + OPENSSL_free(kidpids); sleep(1); exit(ret); } @@ -977,7 +978,6 @@ static void spawn_loop(void) } /* The loop above can only break on termsig */ - OPENSSL_free(kidpids); syslog(LOG_INFO, "terminating on signal: %d", termsig); killall(0, kidpids); } |