diff options
author | Richard Levitte <levitte@openssl.org> | 2016-09-28 23:39:18 +0200 |
---|---|---|
committer | Richard Levitte <levitte@openssl.org> | 2016-10-19 17:44:08 +0200 |
commit | dd1abd4462e4e4fa84b8f8de2ec70375f9b0e191 (patch) | |
tree | 66ed9bf5494cf999e57f754b5fa43ccd51ffc36e /apps/enc.c | |
parent | e972273194303e15f8dd7ce69dbcfa27cc024e9f (diff) |
If an engine comes up explicitely, it must also come down explicitely
In apps/apps.c, one can set up an engine with setup_engine().
However, we freed the structural reference immediately, which means
that for engines that don't already have a structural reference
somewhere else (because it's a built in engine), we end up returning
an invalid reference.
Instead, the function release_engine() is added, and called at the end
of the routines that call setup_engine().
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1643)
Diffstat (limited to 'apps/enc.c')
-rw-r--r-- | apps/enc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/apps/enc.c b/apps/enc.c index 33edd6c2d1..f31e2c8ba7 100644 --- a/apps/enc.c +++ b/apps/enc.c @@ -82,6 +82,7 @@ int enc_main(int argc, char **argv) { static char buf[128]; static const char magic[] = "Salted__"; + ENGINE *e = NULL; BIO *in = NULL, *out = NULL, *b64 = NULL, *benc = NULL, *rbio = NULL, *wbio = NULL; EVP_CIPHER_CTX *ctx = NULL; @@ -151,7 +152,7 @@ int enc_main(int argc, char **argv) passarg = opt_arg(); break; case OPT_ENGINE: - (void)setup_engine(opt_arg(), 0); + e = setup_engine(opt_arg(), 0); break; case OPT_D: enc = 0; @@ -552,6 +553,7 @@ int enc_main(int argc, char **argv) #ifdef ZLIB BIO_free(bzl); #endif + release_engine(e); OPENSSL_free(pass); return (ret); } |