summaryrefslogtreecommitdiffstats
path: root/apps/cmp.c
diff options
context:
space:
mode:
authorPauli <paul.dale@oracle.com>2020-06-29 08:29:10 +1000
committerPauli <paul.dale@oracle.com>2020-07-05 13:20:09 +1000
commit9283e9bd115cac8be3cf4241c8873fc10aeebb2d (patch)
treee568a333eb2bab85d8546e1d77c28ddf3f72cc67 /apps/cmp.c
parentc4d02214053d34990ce28598691f3dddef6f3868 (diff)
cmp: remove NULL check.
Instead appease coverity by marking 1464986 as a false positive. Coverity is confused by the engine reference counting. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/12309)
Diffstat (limited to 'apps/cmp.c')
-rw-r--r--apps/cmp.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/apps/cmp.c b/apps/cmp.c
index 4a6074ba58..87daa37dfa 100644
--- a/apps/cmp.c
+++ b/apps/cmp.c
@@ -3186,8 +3186,7 @@ int cmp_main(int argc, char **argv)
X509_STORE_free(OSSL_CMP_CTX_get_certConf_cb_arg(cmp_ctx));
OSSL_CMP_CTX_free(cmp_ctx);
X509_VERIFY_PARAM_free(vpm);
- if (engine != NULL) /* workaround for Coverity false positive */
- release_engine(engine);
+ release_engine(engine);
NCONF_free(conf); /* must not do as long as opt_... variables are used */
OSSL_CMP_log_close();