summaryrefslogtreecommitdiffstats
path: root/apps/ca.c
diff options
context:
space:
mode:
authorFdaSilvaYY <fdasilvayy@gmail.com>2018-05-08 09:47:26 +0200
committerAndy Polyakov <appro@openssl.org>2018-06-21 15:14:06 +0200
commit991f0355fb782f499e226a732c0099847048c91a (patch)
tree583a439da73a418501b9f2ffa47f70b7ac5d7b5b /apps/ca.c
parent1b712f3fe4752ae1c770f06f957c0e5675b1801c (diff)
apps/ca: fix useless get before delete.
Small simplification by skipping effectively redundant step and not resuming search from point past deletion. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/6195)
Diffstat (limited to 'apps/ca.c')
-rw-r--r--apps/ca.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/apps/ca.c b/apps/ca.c
index 4a8396ee07..558809ee30 100644
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -1706,11 +1706,11 @@ static int do_body(X509 **xret, EVP_PKEY *pkey, X509 *x509,
BIO_printf(bio_err, "Memory allocation failure\n");
goto end;
}
+ i = -1;
while ((i = X509_NAME_get_index_by_NID(dn_subject,
NID_pkcs9_emailAddress,
- -1)) >= 0) {
- tmpne = X509_NAME_get_entry(dn_subject, i);
- X509_NAME_delete_entry(dn_subject, i);
+ i)) >= 0) {
+ tmpne = X509_NAME_delete_entry(dn_subject, i--);
X509_NAME_ENTRY_free(tmpne);
}