diff options
| author | Richard Levitte <levitte@openssl.org> | 2022-07-25 08:07:33 +0200 |
|---|---|---|
| committer | Hugo Landau <hlandau@openssl.org> | 2022-07-26 12:33:28 +0100 |
| commit | c04b8819161de007cee831dd9e58dde52268da18 (patch) | |
| tree | 0d981a1138432a51d25d98a49e6ca83ada687944 /Configurations | |
| parent | ea66c8d85a7104b9da9169e4130bd739215ea12d (diff) | |
Configurations/10-main.conf: In the VC-common target, unquote $(CC)
Some of the VC-common attributes have values that use `$(CC)`, wrapped with
quotes. However, `Configurations/windows-makefile.tmpl` already quotes the
`CC` value, like this:
CC="{- $config{CC} -}"
The interaction between that makefile variable and the attributes using
`$(CC)` wrapped with quotes is a command line with the quotes doubled. For
example, the value of `$(CPP)` becomes `""cl""`.
Strangely enough, this appears to be tolerated, at least on some versions of
Windows. However, this has been reported not to be the case.
This is fixed by removing the quotes in `Configurations/10-main.conf`,
making `Configurations/windows-makefile.tmpl` responsible for proper
quoting.
Fixes #18823
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18861)
Diffstat (limited to 'Configurations')
| -rw-r--r-- | Configurations/10-main.conf | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Configurations/10-main.conf b/Configurations/10-main.conf index c824f4ed4a..73ace78bc4 100644 --- a/Configurations/10-main.conf +++ b/Configurations/10-main.conf @@ -1309,7 +1309,7 @@ my %targets = ( inherit_from => [ "BASE_Windows" ], template => 1, CC => "cl", - CPP => '"$(CC)" /EP /C', + CPP => '$(CC) /EP /C', CFLAGS => "/W3 /wd4090 /nologo", coutflag => "/Fo", LD => "link", @@ -1318,7 +1318,7 @@ my %targets = ( ldpostoutflag => "", ld_resp_delim => "\n", bin_lflags => "setargv.obj", - makedepcmd => '"$(CC)" /Zs /showIncludes', + makedepcmd => '$(CC) /Zs /showIncludes', makedep_scheme => 'VC', AR => "lib", ARFLAGS => "/nologo", |