summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorViktor Dukhovni <openssl-users@dukhovni.org>2015-11-21 00:59:07 -0500
committerViktor Dukhovni <openssl-users@dukhovni.org>2015-11-21 05:23:20 -0500
commit03bf7127808e3a8fbdddda42763458d5da14127e (patch)
tree3153a008a647c6eacaf1ebdac6c2820672261b2d
parent56d913467541506572f908a34c32ca7071f77a94 (diff)
Good hygiene with size_t output argument.
Though the callers check the function return value and ignore the size_t output argument on failure, it is still often not ideal to store -1 in a size_t on error. That might signal an unduly large buffer. Instead set the size_t to 0, to indicate no space. Reviewed-by: Richard Levitte <levitte@openssl.org>
-rw-r--r--ssl/s3_cbc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ssl/s3_cbc.c b/ssl/s3_cbc.c
index f3aa8781e2..557622f513 100644
--- a/ssl/s3_cbc.c
+++ b/ssl/s3_cbc.c
@@ -520,7 +520,7 @@ int ssl3_cbc_digest_record(const EVP_MD_CTX *ctx,
*/
OPENSSL_assert(0);
if (md_out_size)
- *md_out_size = -1;
+ *md_out_size = 0;
return 0;
}