diff options
| author | Peiwei Hu <jlu.hpw@foxmail.com> | 2022-12-02 16:35:53 +0800 |
|---|---|---|
| committer | Tomas Mraz <tomas@openssl.org> | 2022-12-05 13:04:18 +0100 |
| commit | 25d02f333b9a5531fa88db294f69a8347f275858 (patch) | |
| tree | cb095ae1ddb91853d228af198fb9f3e088102e10 | |
| parent | b794476df71441a6d30740ab9fadcc0f6d18d3d6 (diff) | |
Fix the check of BIO_set_write_buffer_size and BIO_set_read_buffer_size
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19819)
| -rw-r--r-- | apps/s_server.c | 4 | ||||
| -rw-r--r-- | crypto/bio/bf_buff.c | 4 | ||||
| -rw-r--r-- | crypto/bio/bf_lbuf.c | 2 | ||||
| -rw-r--r-- | ssl/ssl_lib.c | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/apps/s_server.c b/apps/s_server.c index 46af6b87da..0b794960f9 100644 --- a/apps/s_server.c +++ b/apps/s_server.c @@ -3131,7 +3131,7 @@ static int www_body(int s, int stype, int prot, unsigned char *context) } /* lets make the output buffer a reasonable size */ - if (!BIO_set_write_buffer_size(io, bufsize)) + if (BIO_set_write_buffer_size(io, bufsize) <= 0) goto err; if ((con = SSL_new(ctx)) == NULL) @@ -3560,7 +3560,7 @@ static int rev_body(int s, int stype, int prot, unsigned char *context) goto err; /* lets make the output buffer a reasonable size */ - if (!BIO_set_write_buffer_size(io, bufsize)) + if (BIO_set_write_buffer_size(io, bufsize) <= 0) goto err; if ((con = SSL_new(ctx)) == NULL) diff --git a/crypto/bio/bf_buff.c b/crypto/bio/bf_buff.c index fe0ca92225..b94c58c0a3 100644 --- a/crypto/bio/bf_buff.c +++ b/crypto/bio/bf_buff.c @@ -383,8 +383,8 @@ static long buffer_ctrl(BIO *b, int cmd, long num, void *ptr) break; case BIO_CTRL_DUP: dbio = (BIO *)ptr; - if (!BIO_set_read_buffer_size(dbio, ctx->ibuf_size) || - !BIO_set_write_buffer_size(dbio, ctx->obuf_size)) + if (BIO_set_read_buffer_size(dbio, ctx->ibuf_size) <= 0 || + BIO_set_write_buffer_size(dbio, ctx->obuf_size) <= 0) ret = 0; break; case BIO_CTRL_PEEK: diff --git a/crypto/bio/bf_lbuf.c b/crypto/bio/bf_lbuf.c index 8854b4144c..eb23c88647 100644 --- a/crypto/bio/bf_lbuf.c +++ b/crypto/bio/bf_lbuf.c @@ -281,7 +281,7 @@ static long linebuffer_ctrl(BIO *b, int cmd, long num, void *ptr) break; case BIO_CTRL_DUP: dbio = (BIO *)ptr; - if (!BIO_set_write_buffer_size(dbio, ctx->obuf_size)) + if (BIO_set_write_buffer_size(dbio, ctx->obuf_size) <= 0) ret = 0; break; default: diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c index 118c4d95ba..77abe3dc27 100644 --- a/ssl/ssl_lib.c +++ b/ssl/ssl_lib.c @@ -4816,7 +4816,7 @@ int ssl_init_wbio_buffer(SSL_CONNECTION *s) } bbio = BIO_new(BIO_f_buffer()); - if (bbio == NULL || !BIO_set_read_buffer_size(bbio, 1)) { + if (bbio == NULL || BIO_set_read_buffer_size(bbio, 1) <= 0) { BIO_free(bbio); ERR_raise(ERR_LIB_SSL, ERR_R_BUF_LIB); return 0; |