diff options
| author | ndossche <niels.dossche@ugent.be> | 2023-02-02 16:11:16 +0100 |
|---|---|---|
| committer | Todd Short <todd.short@me.com> | 2023-02-08 10:39:09 -0500 |
| commit | 9b77bd92f898d7ee6a9f135eb39d84591452f330 (patch) | |
| tree | 6f889ef519ea067c833b0fbb82567ea0dbb6af2a | |
| parent | e80518db6d52f9e6faec09df7c25f08a74e8aec2 (diff) | |
Fix incomplete error check on BIO_set_md()
BIO_set_md() can return an error value <= 0 according to my analysis
tool and the documentation. But only an error value == 0 is currently
checked. Fix it by changing the check condition.
CLA: trivial
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from https://github.com/openssl/openssl/pull/20195)
(cherry picked from commit abf654645dee168b229f3fa6a365f6a8e4dd7c31)
| -rw-r--r-- | crypto/cms/cms_lib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/cms/cms_lib.c b/crypto/cms/cms_lib.c index ca9d549fa4..626ca24538 100644 --- a/crypto/cms/cms_lib.c +++ b/crypto/cms/cms_lib.c @@ -431,7 +431,7 @@ BIO *ossl_cms_DigestAlgorithm_init_bio(X509_ALGOR *digestAlgorithm, (void)ERR_pop_to_mark(); mdbio = BIO_new(BIO_f_md()); - if (mdbio == NULL || !BIO_set_md(mdbio, digest)) { + if (mdbio == NULL || BIO_set_md(mdbio, digest) <= 0) { ERR_raise(ERR_LIB_CMS, CMS_R_MD_BIO_INIT_ERROR); goto err; } |