diff options
| author | Rich Salz <rsalz@openssl.org> | 2014-09-04 12:55:31 -0400 |
|---|---|---|
| committer | Rich Salz <rsalz@openssl.org> | 2014-09-08 11:02:54 -0400 |
| commit | 177118fc2b1aa04933d03187cd50ae3a4bfdf3d2 (patch) | |
| tree | 06841354fc67d088de8a7907b755e4c3d9140e88 | |
| parent | 551ed53b2a67581f491fa729a5a5f21c1fa67323 (diff) | |
RT2849: Redundant check of "dsa" variable.
In the current code, the check isn't redundant.
And in fact the REAL check was missing.
This avoids a NULL-deref crash.
Reviewed-by: Dr. Stephen Henson <steve@openssl.org>
| -rw-r--r-- | fips/dsa/fips_dssvs.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fips/dsa/fips_dssvs.c b/fips/dsa/fips_dssvs.c index cee5fb398e..bd7055d463 100644 --- a/fips/dsa/fips_dssvs.c +++ b/fips/dsa/fips_dssvs.c @@ -553,6 +553,11 @@ static void keypair(FILE *in, FILE *out) int n=atoi(value); dsa = FIPS_dsa_new(); + if (!dsa) + { + fprintf(stderr, "DSA allocation error\n"); + exit(1); + } if (!dsa2 && !dsa_builtin_paramgen(dsa, L, N, NULL, NULL, 0, NULL, NULL, NULL, NULL)) { @@ -579,8 +584,7 @@ static void keypair(FILE *in, FILE *out) do_bn_print_name(out, "Y",dsa->pub_key); fputs(RESP_EOL, out); } - if (dsa) - FIPS_dsa_free(dsa); + FIPS_dsa_free(dsa); } } } |