summaryrefslogtreecommitdiffstats
path: root/contrib
diff options
context:
space:
mode:
authorDamien Miller <djm@mindrot.org>2002-01-25 00:46:04 +1100
committerDamien Miller <djm@mindrot.org>2002-01-25 00:46:04 +1100
commit414642b26f2ab3b55786ce23da10166aae026211 (patch)
tree928da3eff1183b7305537b11d8fc20ccd6a3a39a /contrib
parent020daf437b97c4d55268353737861fac60e6a073 (diff)
- (djm) Don't grab Xserver by default. x11-ssh-askpass doesn't and grabbing
can cause deadlocks with kinput2
Diffstat (limited to 'contrib')
-rw-r--r--contrib/gnome-ssh-askpass.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/contrib/gnome-ssh-askpass.c b/contrib/gnome-ssh-askpass.c
index 31aec46b..949b8078 100644
--- a/contrib/gnome-ssh-askpass.c
+++ b/contrib/gnome-ssh-askpass.c
@@ -28,9 +28,9 @@
* gnome-ssh-askpass before calling "ssh-add < /dev/null".
*
* There is only one run-time option: if you set the environment variable
- * "GNOME_SSH_ASKPASS_NOGRAB=true" then gnome-ssh-askpass will not grab
- * the X server. I have found this necessary to avoid server hangs with
- * X input extensions (e.g. kinput2) enabled. - djm
+ * "GNOME_SSH_ASKPASS_GRAB_SERVER=true" then gnome-ssh-askpass will grab
+ * the X server. This may have some benefit to security if you don't trust
+ * your X server. We grab the keyboard and pointer anyway.
*/
/*
@@ -71,7 +71,7 @@ passphrase_dialog(char *message)
int result, i, grab_server;
GtkWidget *dialog, *entry, *label;
- grab_server = (getenv("GNOME_SSH_ASKPASS_NOGRAB") == NULL);
+ grab_server = (getenv("GNOME_SSH_ASKPASS_GRAB_SERVER") != NULL);
dialog = gnome_dialog_new("OpenSSH", GNOME_STOCK_BUTTON_OK,
GNOME_STOCK_BUTTON_CANCEL, NULL);