summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordtucker@openbsd.org <dtucker@openbsd.org>2023-02-27 22:12:40 +0000
committerDarren Tucker <dtucker@dtucker.net>2023-02-28 19:51:21 +1100
commit803392933a3a6f09f834aa5f0c2aab06a3b382f4 (patch)
tree1a06d820cea8a9432b8ec0f9190413236c616dc9
parentaa33b4d396abf47a2a45f982f28d054fb1dcb5c3 (diff)
upstream: Plug mem leak on globbed ls error path.
Spotted by Coverity, ok deraadt@ OpenBSD-Commit-ID: de28476025db29820a9a2e56e98b964d8a02861c
-rw-r--r--sftp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sftp.c b/sftp.c
index b3616c15..deb975cb 100644
--- a/sftp.c
+++ b/sftp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp.c,v 1.225 2023/01/05 05:49:13 djm Exp $ */
+/* $OpenBSD: sftp.c,v 1.226 2023/02/27 22:12:40 dtucker Exp $ */
/*
* Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
*
@@ -1030,6 +1030,7 @@ do_globbed_ls(struct sftp_conn *conn, const char *path,
if (lflag & LS_LONG_VIEW) {
if (g.gl_statv[i] == NULL) {
error("no stat information for %s", fname);
+ free(fname);
continue;
}
lname = ls_file(fname, g.gl_statv[i], 1,