summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordjm@openbsd.org <djm@openbsd.org>2023-03-07 05:37:26 +0000
committerDamien Miller <djm@mindrot.org>2023-03-07 16:38:40 +1100
commit3f9231c2e1f374ebb08016ba00ea97b47c0ed20b (patch)
tree9515ae09853071187f3d23919b2c721f8a0740dd
parentc5e6e890839ec520ab9301a92cba56303749dea2 (diff)
upstream: fix memory leak in process_read() path; Spotted by James
Robinson in GHPR363; ok markus@ OpenBSD-Commit-ID: cdc2d98e6478b7e7f3a36976845adae3820429d8
-rw-r--r--sftp-server.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sftp-server.c b/sftp-server.c
index fe61a351..49ca1ca9 100644
--- a/sftp-server.c
+++ b/sftp-server.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp-server.c,v 1.145 2022/11/09 09:04:12 dtucker Exp $ */
+/* $OpenBSD: sftp-server.c,v 1.146 2023/03/07 05:37:26 djm Exp $ */
/*
* Copyright (c) 2000-2004 Markus Friedl. All rights reserved.
*
@@ -819,7 +819,7 @@ process_read(u_int32_t id)
}
if (len > buflen) {
debug3_f("allocate %zu => %u", buflen, len);
- if ((buf = realloc(NULL, len)) == NULL)
+ if ((buf = realloc(buf, len)) == NULL)
fatal_f("realloc failed");
buflen = len;
}