summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDarren Tucker <dtucker@dtucker.net>2022-08-11 13:33:51 +1000
committerDarren Tucker <dtucker@dtucker.net>2022-08-11 13:50:05 +1000
commit113fe6c77ab43769fc61e953d07cb619fd7ea54b (patch)
tree1e12cd5df7c3d48dbb0ecb11b3086276a1408d40
parentb98a42afb69d60891eb0488935990df6ee571c4d (diff)
Skip hostbased during Valgrind tests.
Valgrind doesn't let ssh exec ssh-keysign (because it's setuid) so skip it during the Valgrind based tests. See https://bugs.kde.org/show_bug.cgi?id=119404 for a discussion of this (ironically there the problematic binary was ssh(1) back when it could still be setuid).
-rwxr-xr-x.github/configs5
1 files changed, 3 insertions, 2 deletions
diff --git a/.github/configs b/.github/configs
index 48070ee7..a853c632 100755
--- a/.github/configs
+++ b/.github/configs
@@ -166,8 +166,9 @@ case "$config" in
case "$config" in
valgrind-1)
# All tests except agent-timeout (which is flaky under valgrind)
- #) and slow ones that run separately to increase parallelism.
- SKIP_LTESTS="agent-timeout ${tests2} ${tests3} ${tests4}"
+ # and hostbased (since valgrind won't let ssh exec keysign).
+ # Slow ones are run separately to increase parallelism.
+ SKIP_LTESTS="agent-timeout hostbased ${tests2} ${tests3} ${tests4}"
;;
valgrind-2)
LTESTS="${tests2}"