diff options
| author | Jani Nikula <jani@nikula.org> | 2016-11-21 22:14:33 +0200 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2016-11-25 21:09:32 -0400 |
| commit | f5185881f7b01f67b5b64218804749b733f08d44 (patch) | |
| tree | f640a2dcaffa6b9b2337133c69bc2fdcf647cbd7 /notmuch-client.h | |
| parent | 3891d6cb98ebd9940d947d963e0528cc2db9a752 (diff) | |
cli: consider files vanishing during notmuch new non-fatal
If some software other than notmuch new renames or removes files
during the notmuch new scan (specifically after scandir but before
indexing the file), keep going instead of bailing out. Failing to
index the file is just a race condition between notmuch and the other
software; the rename could happen after the notmuch new scan
anyway. It's not fatal, and we'll catch the renamed files on the next
scan.
Add a new exit code for when files vanished, so the caller has a
chance to detect the race and re-run notmuch new to recover.
Reported by Paul Wise <pabs@debian.org> at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843127
Diffstat (limited to 'notmuch-client.h')
| -rw-r--r-- | notmuch-client.h | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/notmuch-client.h b/notmuch-client.h index 9ce2aef1..793f32ec 100644 --- a/notmuch-client.h +++ b/notmuch-client.h @@ -25,6 +25,7 @@ #define _GNU_SOURCE /* for getline */ #endif #include <stdio.h> +#include <sysexits.h> #include "compat.h" @@ -114,6 +115,16 @@ chomp_newline (char *str) str[strlen(str)-1] = '\0'; } +/* Exit status code indicating temporary failure; user is invited to + * retry. + * + * For example, file(s) in the mail store were removed or renamed + * after notmuch new scanned the directories but before indexing the + * file(s). If the file was renamed, the indexing might not be + * complete, and the user is advised to re-run notmuch new. + */ +#define NOTMUCH_EXIT_TEMPFAIL EX_TEMPFAIL + /* Exit status code indicating the requested format version is too old * (support for that version has been dropped). CLI code should use * notmuch_exit_if_unsupported_format rather than directly exiting |