Age | Commit message (Collapse) | Author |
|
See also https://github.com/NixOS/nix.dev/pull/978
|
|
contributing: update link to rebasing+squashing
|
|
We use angle brackets since they look a lot like a placeholder while
also being valid nix code, as suggested by roberth here: https://github.com/NixOS/nixpkgs/pull/299554#discussion_r1541797970
|
|
This allows for correct highlighting and maybe future automatic
formatting. The AST was verified to work with nixfmt only.
|
|
The graph right above the table has the order as `master` ⇒ `staging-next` ⇒ `staging`.
This corresponds with the workflow, i.e. automatic merges happen in that direction and the manual merging is in reverse direction of that.
As a first time reader of this document the table was very confusing due to the disparity of that.
With this change the table should read more fluently for people not familiar with the workflow since the table follows the step-by-step flow of commits.
Signed-off-by: benaryorg <binary@benary.org>
|
|
The fact that sandboxing is already enabled by default is mentioned in
the pull request template. Hence, it might be confusing to ask to enable
sandboxing in CONTRIBUTING.md.
Also follow the `one sentence per line` guideline.
Co-authored-by: Silvan Mosberger <github@infinisil.com>
|
|
|
|
|
|
https://github.com/orgs/community/discussions/16925#discussioncomment-7574895
|
|
GitHub supported special markdown syntax for emphasising blocks for some
time. This was however a beta feature, and still is, so it's subject to
changes.
Recently such a change happened: The syntax is different now.
See https://github.com/orgs/community/discussions/16925 for more
information
|
|
|
|
doc: commit header convention for documentation changes
|
|
|
|
CONTRIBUTING: Add hotlinks to package and module reviewing guides, minor touchups
|
|
references
|
|
Using the script in maintainers/scripts/update-redirected-urls.sh
|
|
|
|
|
|
|
|
It wasn't entirely clear if the list was acceptable or not from the
wording.
|
|
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
|
|
|
Particularities about style should be enforced at the tooling level (linters,
code beautifiers etc.). Otherwise, it adds more weight on the PR reviewing,
distracting both authors and reviewers from the substance of the changes.
|
|
This needs a rewrite at some point..
|
|
- Fix sentence about meeting contributing standards
- pkgs -> packages
- Use emoji's because GitHub renders the :*: things weird sometimes
- Move a dot
Co-authored-by: Rémi NICOLE <minijackson@users.noreply.github.com>
|
|
- Contributing without a GitHub account
- Mention OfBorg
- nix.useSandbox -> nix.settings.sandbox
- nixpkgs-review is good for not just version updates
Co-authored-by: Rémi NICOLE <minijackson@users.noreply.github.com>
|
|
Yeah I'm totally getting lazy with the commits, but it's really hard and
takes a long time..
|
|
|
|
|
|
Right into the "How to propose a change" section, because that's where
it's relevant
|
|
How to force push to PR's is already explained in the
"How to propose a change" section at the beginning
|
|
|
|
|
|
Will be cleaned up in the next commit
|
|
|
|
Can't be rendered in GitHub markdown, replacing it with a Git branch diagram using mermaid
|
|
|
|
Moving and collecting bits into the appropriate places, also writing
some new sentences
|
|
Removing paragraphs from the other sections that aren't necessary anymore
|
|
It's not conventions about how to do coding, it's about what the code
should look like
|
|
|
|
|
|
|
|
|
|
The -new version was assembled in the previous commits
|
|
So that the CONTRIBUTING-new.md can take its place and Git detect the
rename
|
|
This isn't relevant to contributors specifically, it applies to all
users
|
|
No content was changed, new titles are wrapped with () to signal that
they will need to be decided on in a future commit.
|
|
|
|
As a beginning contributor, it is far from obvious where to find tests,
how to run individual tests locally for quick development, and which
tests do what. The new "Testing changes" section aims to help with all
of these.
Co-authored-by: Emily <git@emilylange.de>
|