diff options
author | Matthew Bauer <mjbauer95@gmail.com> | 2019-01-27 17:02:17 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-01-27 17:02:17 -0500 |
commit | ae16dd1a15dfbe29c6a1de61c4cc23e2cd6487f0 (patch) | |
tree | b0c1ca1dd5b947c65987f76aa18bbd114938ba35 /pkgs | |
parent | 39fdfd0eb1c837f0a59764c54e883e7bc1bd44ac (diff) |
stdenv/make-derivation: don't hide broken packages
This behavior ended up breaking the handleEvalIssue functionality by hiding those packages. So something like this:
$ nix-env -iA nixpkgs.zoom-us
would silently fail, without telling the user how to fix it! Regardless, this "bug" should be handled in Nix - not Nixpkgs.
Fixes #38952.
Diffstat (limited to 'pkgs')
-rw-r--r-- | pkgs/stdenv/generic/make-derivation.nix | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/pkgs/stdenv/generic/make-derivation.nix b/pkgs/stdenv/generic/make-derivation.nix index f3c4afb613e6..c646b6d715bd 100644 --- a/pkgs/stdenv/generic/make-derivation.nix +++ b/pkgs/stdenv/generic/make-derivation.nix @@ -180,9 +180,7 @@ rec { "__impureHostDeps" "__propagatedImpureHostDeps" "sandboxProfile" "propagatedSandboxProfile"]) // { - # A hack to make `nix-env -qa` and `nix search` ignore broken packages. - # TODO(@oxij): remove this assert when something like NixOS/nix#1771 gets merged into nix. - name = assert validity.handled; computedName + lib.optionalString + name = computedName + lib.optionalString # Fixed-output derivations like source tarballs shouldn't get a host # suffix. But we have some weird ones with run-time deps that are # just used for their side-affects. Those might as well since the |