diff options
author | John Ericson <mail@JohnEricson.me> | 2018-08-20 13:09:15 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-08-20 13:09:15 -0400 |
commit | 3cf43547f4be03d1d6eb0bbfc557e2dbc13b4095 (patch) | |
tree | 6a24a3399dd0aff40e616b428ee084f82ed936fd /doc | |
parent | f8f6ab3e8293e823954490a0e9d48e3933c1e326 (diff) |
lib: Use lib.fixed-points.extends to avoid repetition
Another attempt after my sloppy https://github.com/NixOS/nixpkgs/commit/48ccdf322d9e7a68d0caf5833511ee3e53ec7d3a.
@Infinisil, thanks again, reverted in https://github.com/NixOS/nixpkgs/commit/4794aa5de233b5bf2d1c3245946379699d023467 and explained my mistakes in https://github.com/NixOS/nixpkgs/commit/48ccdf322d9e7a68d0caf5833511ee3e53ec7d3a#commitcomment-29678643. I start with their work and provide this proof of this commit's correctness:
```nix
(lib.fixedPoints.extends (lib.flip g) f) # now
((f: rattrs: self: let super = rattrs self; in super // f self super) (lib.flip g) f) # inline extends
(self: let super = f self; in super // (lib.flip g) self super) # beta reduce
(self: let super = f self; in super // g super self) # beta reduce
(self_: let super = f self_; in super // g super self_) # alpha rename
(self_: let super = f self_; in super // g super self_) # original, same
```
Eventually we might harmonize `overrideScope`'s `g` parameter with the general pattern, but I leave that breaking change as a separate step. Best not to refactor and break at once, and at least the abstractions make the oddity clearer.
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions