From 814bd1a02422e7007fe469442c94f1ec54b065d6 Mon Sep 17 00:00:00 2001
From: Tom Bereknyei <tomberek@gmail.com>
Date: Thu, 18 Jul 2019 15:19:31 -0400
Subject: Initial 15-7590

---
 dell/xps/15-7590/README.wiki | 46 ++++++++++++++++++++++++++++++++++++++++++++
 dell/xps/15-7590/default.nix | 14 ++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 dell/xps/15-7590/README.wiki
 create mode 100644 dell/xps/15-7590/default.nix

diff --git a/dell/xps/15-7590/README.wiki b/dell/xps/15-7590/README.wiki
new file mode 100644
index 0000000..b323b31
--- /dev/null
+++ b/dell/xps/15-7590/README.wiki
@@ -0,0 +1,46 @@
+= Dell XPS 15 7590 =
+*Mostly copied from 15-9550
+
+== Tested Hardware ==
+
+* CPU: Intel(R) Core(TM) i9-9980HK
+* RAM: 32 GB
+* HDD: 1 TiB SSD
+* Screen: 15" 4k (3840✕2160)
+* Input: Touchscreen and trackpad.
+
+== Firmware Configuration ==
+
+Not much tweaking of NixOS itself was needed. But we currently cannot automate the firmware setup, so this must be done by hand.
+
+=== Before installation ===
+
+These settings are needed both for booting the final install, and installer itself. Therefore, they must be done first.
+
+* ''Disable Secure Boot (but keep UEFI Boot).'' Thakfully doing so is as easy as changing any other simple setting.
+
+* ''Disable Intel hardware RAID and use AHCI instead.'' Intel doesn't seem to provide a working linux driver for this.  (If you just have SSD it's pointless and just slows things down needlessly anyways.)
+
+=== Wifi ===
+Wifi does not work with kernels older than 5.1 (firmware not present) or newer (https://bbs.archlinux.org/viewtopic.php?id=247705)
+```
+  # Use the systemd-boot EFI boot loader.
+  boot.loader.systemd-boot.enable = true;
+  boot.loader.grub = {
+    device = "nodev";
+    efiSupport = true;
+    efiInstallAsRemovable = true;
+  };
+  boot.loader.efi.canTouchEfiVariables = true;
+  boot.kernelPackages = pkgs.linuxPackages_5_1;
+```
+=== After installation ===
+
+* ''Add systemd-boot to UEFI boot list.'' The (uneditable anyways) settings mapping drive UUIDs to HD* work fine.
+
+=== Optional ===
+
+* ''Update BIOS.'' According to Reddit, this helps with battery life.
+
+=== Troubleshooting ===
+
diff --git a/dell/xps/15-7590/default.nix b/dell/xps/15-7590/default.nix
new file mode 100644
index 0000000..a3540e7
--- /dev/null
+++ b/dell/xps/15-7590/default.nix
@@ -0,0 +1,14 @@
+{ lib, ... }:
+
+{
+  imports = [
+    ../../../common/cpu/intel
+    ../../../common/pc/laptop
+  ];
+
+  # TODO: boot loader
+  boot.loader.systemd-boot.enable = lib.mkDefault true;
+  boot.kernelPackages = pkgs.linuxPackages_5_1;
+  boot.loader.efi.canTouchEfiVariables = lib.mkDefault true;
+
+}
-- 
cgit v1.2.3