1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
|
<!--
- @copyright Copyright (c) 2022 Marco Ambrosini <marcoambrosini@icloud.com>
-
- @author Marco Ambrosini <marcoambrosini@icloud.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-->
<template>
<div class="participants-editor">
<NcActions v-if="hasSelected" :menu-title="t('spreed', 'Assign participants to room')">
<NcActionButton v-for="(item, index) in assignments" :key="index" @click="assignAttendees(index)">
<template #icon>
<!-- TODO: choose final icon -->
<GoogleCircles :size="20" />
</template>
{{ roomName(index) }}
</NcActionButton>
<NcActionButton>
<template #icon>
<Reload :size="20" />
</template>
{{ t('spreed', 'Reset all assignments') }}
</NcActionButton>
</NcActions>
<NcAppNavigationItem key="unassigned"
:title="t('spreed', 'Unassigned participants')"
:allow-collapse="true"
:open="true">
<template #icon>
<GoogleCircles :size="20" />
</template>
<SelectableParticipant v-for="participant in unassignedParticipants"
:key="participant.attendeeId"
:value="participant.attendeeId"
:checked.sync="selectedParticipants"
:participant="participant" />
</NcAppNavigationItem>
<template v-for="(item, index) in assignments">
<NcAppNavigationItem :key="index"
:title="roomName(index)"
:allow-collapse="true"
:open="true">
<template #icon>
<GoogleCircles :size="20" />
</template>
<!-- Template should be simple, declarative, without calling methods when possible -->
<!-- A method is call each time on each re-render for each loop iteration -->
<!-- Not cool for perf as well -->
<SelectableParticipant v-for="attendeeId in item"
:key="attendeeId"
:value="assignments"
:checked.sync="selectedParticipants"
:participant="attendeesById[attendeeId]" />
</NcAppNavigationItem>
</template>
</div>
</template>
<script>
import NcActions from '@nextcloud/vue/dist/Components/NcActions.js'
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'
import GoogleCircles from 'vue-material-design-icons/GoogleCircles.vue'
import Reload from 'vue-material-design-icons/Reload.vue'
import NcAppNavigationItem from '@nextcloud/vue/dist/Components/NcAppNavigationItem.js'
import SelectableParticipant from './SelectableParticipant.vue'
export default {
name: 'BreakoutRoomsParticipantsEditor',
components: {
NcActions,
NcActionButton,
GoogleCircles,
Reload,
NcAppNavigationItem,
SelectableParticipant,
},
props: {
token: {
type: String,
required: true,
},
roomNumber: {
type: Number,
default: 3,
},
},
data() {
return {
selectedParticipants: [],
assignments: [],
}
},
computed: {
participants() {
return this.$store.getters.participantsList(this.token)
},
// Should be a getter in Vuex?
attendeesById() {
// Just get all attendees for this conversation without mapping to an array
// Like participants, but object, not array
return this.$store.state.participants.attendees[this.token]
},
unassignedParticipants() {
if (this.assignments.length === 0) {
return []
}
// Flatten assignments array
const assignedParticipants = this.assignments.flat()
return this.participants.filter(participant => {
return !assignedParticipants.includes(participant.attendeeId)
})
},
hasSelected() {
return this.selectedParticipants.length !== 0
},
},
created() {
this.initialiseAssignments()
},
methods: {
initialiseAssignments() {
// let count = 0
// while (count < this.roomNumber) {
// this.assignments.push([])
// count++
// }
// Just more clean for me
// If it looks complex - then I'd prefer "for" instead of "while". It's fixed
this.assignments = Array.from(Array(this.roomNumber), () => [])
},
assignAttendees(roomIndex) {
this.assignments[roomIndex].push(...this.selectedParticipants)
this.selectedParticipants = []
},
roomName(index) {
const roomNumber = index + 1
return t('spreed', 'Room {roomNumber}', { roomNumber })
},
// This is not fast. Loop over all the participants, for each participant loop again in assignments.
// And it is called each time in v-for on each re-render.
// Also - this is not a vue-way
// filteredParticipants(index) {
// return this.participants.filter(participant => {
// return this.assignments[index].includes(participant.attendeeId)
// })
// },
},
}
</script>
<style lang="scss" scoped>
.participants-editor {
display: flex;
flex-direction: column;
gap: var(--default-grid-baseline);
&__participant {
display: flex;
align-items: center;
gap: var(--default-grid-baseline);
margin-left: 14px;
}
}
</style>
|