Merge pull request #12531 from nextcloud/skalidindi53/11852/Duplicate-Stun-and-Turn-Servers

fix: duplicate stun and turn servers cannot be added

2 files changed, 21 insertions, 0 deletions

diff --git a/lib/Command/Stun/Add.php b/lib/Command/Stun/Add.php
index 9c47eb31b..2e7bbaba8 100644
--- a/lib/Command/Stun/Add.php
+++ b/lib/Command/Stun/Add.php
@@ -50,6 +50,14 @@ class Add extends Base {
 			$servers = [];
 		}
 
+		// check if the server is already in the list
+		foreach ($servers as $existingServer) {
+			if ($existingServer === "$host:$port") {
+				$output->writeln('<error>Server already exists.</error>');
+				return 1;
+			}
+		}
+
 		$servers[] = "$host:$port";
 
 		$this->config->setAppValue('spreed', 'stun_servers', json_encode($servers));
diff --git a/lib/Command/Turn/Add.php b/lib/Command/Turn/Add.php
index 7bae8645c..6cec353d3 100644
--- a/lib/Command/Turn/Add.php
+++ b/lib/Command/Turn/Add.php
@@ -98,6 +98,19 @@ class Add extends Base {
 			$servers = [];
 		}
 
+		//Checking if the server is already added
+		foreach ($servers as $existingServer) {
+			if (
+				$existingServer['schemes'] === $schemes &&
+				$existingServer['server'] === $server &&
+				$existingServer['protocols'] === $protocols
+			) {
+				$output->writeln('<error>Server already exists with the same configuration.</error>');
+				return 1;
+			}
+		}
+
+
 		$servers[] = [
 			'schemes' => $schemes,
 			'server' => $server,