summaryrefslogtreecommitdiffstats
path: root/lib/Notification/Notifier.php
diff options
context:
space:
mode:
authorJoas Schilling <coding@schilljs.com>2023-11-15 11:42:11 +0100
committerJoas Schilling <coding@schilljs.com>2023-11-16 14:30:53 +0100
commitf2f5e4b393327592f8f8047b8123c3e0e0971748 (patch)
treef160042b45ba962800aafc91847f089b682fe775 /lib/Notification/Notifier.php
parentde674332925dafffb84087ca4bdf220ecd23399b (diff)
fix(notifications): Also handle reaction notifications a bit better
Signed-off-by: Joas Schilling <coding@schilljs.com>
Diffstat (limited to 'lib/Notification/Notifier.php')
-rw-r--r--lib/Notification/Notifier.php8
1 files changed, 5 insertions, 3 deletions
diff --git a/lib/Notification/Notifier.php b/lib/Notification/Notifier.php
index 086fb2418..22e51ebc3 100644
--- a/lib/Notification/Notifier.php
+++ b/lib/Notification/Notifier.php
@@ -529,9 +529,11 @@ class Notifier implements INotifier {
if (!$this->notificationManager->isPreparingPushNotification()
&& $notification->getObjectType() === 'chat'
- // FIXME Need to solve the same bug for reactions as well,
- // but the notification only contains the message id of the target
- // not the one of the reaction, so we can't determine if it was read.
+ /**
+ * Notification only contains the message id of the target comment
+ * not the one of the reaction, so we can't determine if it was read.
+ * @see Listener::markReactionNotificationsRead()
+ */
&& $notification->getSubject() !== 'reaction'
&& ((int) $messageParameters['commentId']) <= $participant->getAttendee()->getLastReadMessage()) {
// Mark notifications of messages that are read as processed