diff options
author | marco <marcoambrosini@pm.me> | 2021-08-31 14:35:06 +0200 |
---|---|---|
committer | marco <marcoambrosini@pm.me> | 2021-08-31 14:35:06 +0200 |
commit | 5f20110113f42bcdd3c196ddaf96cba6183241e2 (patch) | |
tree | f6b17ed8120f3766faf962708c3159916f78d943 | |
parent | 1674b09dfc0d6196d1aa14137f999fbe5b6b673f (diff) |
Fix remaining warnings
Signed-off-by: marco <marcoambrosini@pm.me>
-rw-r--r-- | .eslintrc.js | 16 | ||||
-rw-r--r-- | babel.config.js | 2 | ||||
-rw-r--r-- | src/components/AdminSettings/Commands.vue | 1 | ||||
-rw-r--r-- | src/components/AdminSettings/HostedSignalingServer.vue | 1 | ||||
-rw-r--r-- | src/components/AdminSettings/MatterbridgeIntegration.vue | 2 | ||||
-rw-r--r-- | src/components/AdminSettings/TurnServers.vue | 1 | ||||
-rw-r--r-- | src/store/participantsStore.js | 2 | ||||
-rw-r--r-- | src/utils/webrtc/MediaDevicesManager.js | 6 | ||||
-rw-r--r-- | src/utils/webrtc/SentVideoQualityThrottler.js | 4 | ||||
-rw-r--r-- | src/utils/webrtc/SpeakingWhileMutedWarner.js | 12 | ||||
-rw-r--r-- | src/utils/webrtc/VideoConstrainer.js | 2 | ||||
-rw-r--r-- | src/utils/webrtc/analyzers/CallAnalyzer.js | 10 | ||||
-rw-r--r-- | src/utils/webrtc/simplewebrtc/localmedia.js | 6 | ||||
-rw-r--r-- | src/utils/webrtc/simplewebrtc/peer.js | 6 | ||||
-rw-r--r-- | src/utils/webrtc/simplewebrtc/simplewebrtc.js | 2 | ||||
-rw-r--r-- | src/utils/webrtc/simplewebrtc/webrtc.js | 2 |
16 files changed, 40 insertions, 35 deletions
diff --git a/.eslintrc.js b/.eslintrc.js index bdeb502d9..2d21344cf 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1,13 +1,13 @@ module.exports = { extends: [ - '@nextcloud' + '@nextcloud', ], overrides: [ { - 'files': ['**/*.spec.js'], - 'rules': { - 'node/no-unpublished-import': 0 - } - } - ] -}
\ No newline at end of file + files: ['**/*.spec.js'], + rules: { + 'node/no-unpublished-import': 0, + }, + }, + ], +} diff --git a/babel.config.js b/babel.config.js index bd8e2cb2b..8be4fc38b 100644 --- a/babel.config.js +++ b/babel.config.js @@ -1,3 +1,3 @@ const babelConfig = require('@nextcloud/babel-config') -module.exports = babelConfig
\ No newline at end of file +module.exports = babelConfig diff --git a/src/components/AdminSettings/Commands.vue b/src/components/AdminSettings/Commands.vue index c3d4b22b2..c2ff5569e 100644 --- a/src/components/AdminSettings/Commands.vue +++ b/src/components/AdminSettings/Commands.vue @@ -30,6 +30,7 @@ </small> </h2> + <!-- eslint-disable-next-line vue/no-v-html --> <p class="settings-hint" v-html="commandHint" /> <div id="commands_list"> diff --git a/src/components/AdminSettings/HostedSignalingServer.vue b/src/components/AdminSettings/HostedSignalingServer.vue index 4fe2d38a4..e9aaf672b 100644 --- a/src/components/AdminSettings/HostedSignalingServer.vue +++ b/src/components/AdminSettings/HostedSignalingServer.vue @@ -95,6 +95,7 @@ {{ requestError }} </p> + <!-- eslint-disable-next-line vue/no-v-html --> <p class="settings-hint additional-top-margin" v-html="disclaimerHint" /> </div> <div v-else> diff --git a/src/components/AdminSettings/MatterbridgeIntegration.vue b/src/components/AdminSettings/MatterbridgeIntegration.vue index 81301f957..379c519f0 100644 --- a/src/components/AdminSettings/MatterbridgeIntegration.vue +++ b/src/components/AdminSettings/MatterbridgeIntegration.vue @@ -47,8 +47,10 @@ </template> <template v-else> + <!-- eslint-disable-next-line vue/no-v-html --> <p class="settings-hint" v-html="description" /> + <!-- eslint-disable-next-line vue/no-v-html --> <p class="settings-hint" v-html="customBinaryText" /> <p v-if="errorText" class="settings-hint"> diff --git a/src/components/AdminSettings/TurnServers.vue b/src/components/AdminSettings/TurnServers.vue index 2dc9c6c66..a76806e9d 100644 --- a/src/components/AdminSettings/TurnServers.vue +++ b/src/components/AdminSettings/TurnServers.vue @@ -34,6 +34,7 @@ <span v-else class="icon icon-loading-small" /> </h2> + <!-- eslint-disable-next-line vue/no-v-html --> <p class="settings-hint" v-html="documentationHint" /> <ul class="turn-servers"> diff --git a/src/store/participantsStore.js b/src/store/participantsStore.js index 0123b33d5..3ec1ac21b 100644 --- a/src/store/participantsStore.js +++ b/src/store/participantsStore.js @@ -432,7 +432,7 @@ const actions = { // not listen to when it was used. const interval = setInterval(function() { // eslint-disable-next-line no-undef - if ($('.oc-dialog-dim').length === 0) { + if (document.getElementsByClassName('oc-dialog-dim').length === 0) { clearInterval(interval) EventBus.$emit('duplicate-session-detected') window.location = generateUrl('/apps/spreed') diff --git a/src/utils/webrtc/MediaDevicesManager.js b/src/utils/webrtc/MediaDevicesManager.js index e9d6b8a13..ee082d34b 100644 --- a/src/utils/webrtc/MediaDevicesManager.js +++ b/src/utils/webrtc/MediaDevicesManager.js @@ -364,10 +364,10 @@ MediaDevicesManager.prototype = { * For compatibility with older browsers "finally" should not be used on the * returned Promise. * - * @param {MediaStreamConstraints} constraints the constraints specifying - * the media to request + * @param {object} constraints the constraints specifying + * the media to request. * @return {Promise} resolved with a MediaStream object when successful, or - * rejected with a DOMException in case of error + * rejected with a DOMException in case of error. */ getUserMedia(constraints) { if (!this.isSupported()) { diff --git a/src/utils/webrtc/SentVideoQualityThrottler.js b/src/utils/webrtc/SentVideoQualityThrottler.js index 8822e5b2b..dd1a8c6bc 100644 --- a/src/utils/webrtc/SentVideoQualityThrottler.js +++ b/src/utils/webrtc/SentVideoQualityThrottler.js @@ -34,8 +34,8 @@ import { * increase the video quality depending on the call state. Basically the goal is * to reduce the CPU usage when there are too many participants in a call. * - * @param {LocalMediaModel} localMediaModel the model for the local media. - * @param {CallParticipantCollection} callParticipantCollection the collection + * @param {object} localMediaModel the model for the local media. + * @param {object} callParticipantCollection the collection. * that contains the models for the rest of the participants in the call. */ export default function SentVideoQualityThrottler(localMediaModel, callParticipantCollection) { diff --git a/src/utils/webrtc/SpeakingWhileMutedWarner.js b/src/utils/webrtc/SpeakingWhileMutedWarner.js index 75f4b2250..bf13984ac 100644 --- a/src/utils/webrtc/SpeakingWhileMutedWarner.js +++ b/src/utils/webrtc/SpeakingWhileMutedWarner.js @@ -40,13 +40,13 @@ * to the user even if the browser window is not in the foreground (provided * the user granted the permissions to receive notifications from the site). * - * @param {LocalMediaModel} model the model that emits "speakingWhileMuted" - * events - * @param {View} view the view that provides the - * "setSpeakingWhileMutedNotification" method + * @param {object} LocalMediaModel the model that emits "speakingWhileMuted" + * events. + * @param {object} view the view that provides the + * "setSpeakingWhileMutedNotification" method. */ -export default function SpeakingWhileMutedWarner(model, view) { - this._model = model +export default function SpeakingWhileMutedWarner(LocalMediaModel, view) { + this._model = LocalMediaModel this._view = view this._handleSpeakingWhileMutedChangeBound = this._handleSpeakingWhileMutedChange.bind(this) diff --git a/src/utils/webrtc/VideoConstrainer.js b/src/utils/webrtc/VideoConstrainer.js index 381244fd3..511e6b41a 100644 --- a/src/utils/webrtc/VideoConstrainer.js +++ b/src/utils/webrtc/VideoConstrainer.js @@ -40,7 +40,7 @@ const QUALITY = { * a simple interface to set the constraints based on some general quality * description. * - * @param {LocalMediaModel} localMediaModel the model for the local media. + * @param {object} localMediaModel the model for the local media. */ function VideoConstrainer(localMediaModel) { this._localMediaModel = localMediaModel diff --git a/src/utils/webrtc/analyzers/CallAnalyzer.js b/src/utils/webrtc/analyzers/CallAnalyzer.js index aff43ae0d..689fb5d7d 100644 --- a/src/utils/webrtc/analyzers/CallAnalyzer.js +++ b/src/utils/webrtc/analyzers/CallAnalyzer.js @@ -43,11 +43,11 @@ import { * Once the CallAnalyzer is no longer needed "destroy()" must be called to stop * the analysis. * - * @param {LocalMediaModel} localMediaModel the model for the local media. - * @param {LocalCallParticipantModel} localCallParticipantModel the model for - * the local participant; null if an MCU is not used. - * @param {CallParticipantCollection} callParticipantCollection the collection - * for the remote participants. + * @param {object} localMediaModel the model for the local media. + * @param {object} localCallParticipantModel the model for + * the local participant; null if an MCU is not used. + * @param {object} callParticipantCollection the collection + * for the remote participants. */ export default function CallAnalyzer(localMediaModel, localCallParticipantModel, callParticipantCollection) { this.attributes = { diff --git a/src/utils/webrtc/simplewebrtc/localmedia.js b/src/utils/webrtc/simplewebrtc/localmedia.js index 9192e8ceb..6424c1807 100644 --- a/src/utils/webrtc/simplewebrtc/localmedia.js +++ b/src/utils/webrtc/simplewebrtc/localmedia.js @@ -11,7 +11,7 @@ const UAParser = require('ua-parser-js') const webrtcIndex = require('../index.js') /** - * @param stream + * @param {object} stream the stream object. */ function isAllTracksEnded(stream) { let isAllTracksEnded = true @@ -22,7 +22,7 @@ function isAllTracksEnded(stream) { } /** - * @param stream + * @param {object} stream the stream object. */ function isAllAudioTracksEnded(stream) { let isAllAudioTracksEnded = true @@ -33,7 +33,7 @@ function isAllAudioTracksEnded(stream) { } /** - * @param opts + * @param {object} opts the options object. */ function LocalMedia(opts) { WildEmitter.call(this) diff --git a/src/utils/webrtc/simplewebrtc/peer.js b/src/utils/webrtc/simplewebrtc/peer.js index 5e40e6d9b..0d1aac24b 100644 --- a/src/utils/webrtc/simplewebrtc/peer.js +++ b/src/utils/webrtc/simplewebrtc/peer.js @@ -8,7 +8,7 @@ const webrtcSupport = require('webrtcsupport') const WildEmitter = require('wildemitter') /** - * @param stream + * @param {object} stream the stream object. */ function isAllTracksEnded(stream) { let isAllTracksEnded = true @@ -19,7 +19,7 @@ function isAllTracksEnded(stream) { } /** - * @param options + * @param {object} options the options object. */ function Peer(options) { const self = this @@ -144,7 +144,7 @@ function shouldPreferH264() { } /** - * @param sessionDescription + * @param {string} sessionDescription the session description. */ function preferH264VideoCodecIfAvailable(sessionDescription) { const sdpInfo = sdpTransform.parse(sessionDescription.sdp) diff --git a/src/utils/webrtc/simplewebrtc/simplewebrtc.js b/src/utils/webrtc/simplewebrtc/simplewebrtc.js index d1dbee6e1..39da2f1f0 100644 --- a/src/utils/webrtc/simplewebrtc/simplewebrtc.js +++ b/src/utils/webrtc/simplewebrtc/simplewebrtc.js @@ -7,7 +7,7 @@ const attachMediaStream = require('attachmediastream') const mockconsole = require('mockconsole') /** - * @param opts + * @param {object} opts the options object. */ function SimpleWebRTC(opts) { const self = this diff --git a/src/utils/webrtc/simplewebrtc/webrtc.js b/src/utils/webrtc/simplewebrtc/webrtc.js index 7cfd08662..f335a9788 100644 --- a/src/utils/webrtc/simplewebrtc/webrtc.js +++ b/src/utils/webrtc/simplewebrtc/webrtc.js @@ -7,7 +7,7 @@ const localMedia = require('./localmedia') const Peer = require('./peer') /** - * @param opts + * @param {object} opts the options object. */ function WebRTC(opts) { const self = this |