From 6cd83ea1da4d24d439a5f30bfc13349f0c25e597 Mon Sep 17 00:00:00 2001 From: Benjamin Brahmer Date: Thu, 11 Feb 2021 07:56:31 +0100 Subject: remove unused lastModified from feed fetcher Signed-off-by: Benjamin Brahmer --- tests/Unit/Command/ShowFeedTest.php | 4 ++-- tests/Unit/Fetcher/FeedFetcherTest.php | 15 +++++++-------- tests/Unit/Fetcher/FetcherTest.php | 3 +-- 3 files changed, 10 insertions(+), 12 deletions(-) (limited to 'tests') diff --git a/tests/Unit/Command/ShowFeedTest.php b/tests/Unit/Command/ShowFeedTest.php index 6383c3f19..ace16e0af 100644 --- a/tests/Unit/Command/ShowFeedTest.php +++ b/tests/Unit/Command/ShowFeedTest.php @@ -72,7 +72,7 @@ class ShowFeedTest extends TestCase $this->fetcher->expects($this->exactly(1)) ->method('fetch') - ->with('feed', null, true, 'user', 'user') + ->with('feed', true, 'user', 'user') ->willReturn([['feed'], [['items']]]); $this->consoleOutput->expects($this->exactly(2)) @@ -106,7 +106,7 @@ class ShowFeedTest extends TestCase $this->fetcher->expects($this->exactly(1)) ->method('fetch') - ->with('feed', null, true, 'user', 'user') + ->with('feed', true, 'user', 'user') ->will($this->throwException(new ServiceNotFoundException('test'))); $this->consoleOutput->expects($this->exactly(2)) diff --git a/tests/Unit/Fetcher/FeedFetcherTest.php b/tests/Unit/Fetcher/FeedFetcherTest.php index 4d5f45f73..ead4a67eb 100644 --- a/tests/Unit/Fetcher/FeedFetcherTest.php +++ b/tests/Unit/Fetcher/FeedFetcherTest.php @@ -310,7 +310,7 @@ class FeedFetcherTest extends TestCase $item = $this->createItem(); $feed = $this->createFeed(); $this->mockIterator($this->feed_mock, [$this->item_mock]); - $result = $this->fetcher->fetch($this->url, '@1553118393', false, null, null); + $result = $this->fetcher->fetch($this->url, false, null, null); $this->assertEquals([$feed, [$item]], $result); } @@ -326,7 +326,6 @@ class FeedFetcherTest extends TestCase $this->mockIterator($this->feed_mock, [$this->item_mock]); $result = $this->fetcher->fetch( $this->url, - '@1553118393', false, 'account@email.com', 'F9sEU*Rt%:KFK8HMHT&' @@ -344,7 +343,7 @@ class FeedFetcherTest extends TestCase $item = $this->createItem('audio/ogg'); $feed = $this->createFeed(); $this->mockIterator($this->feed_mock, [$this->item_mock]); - $result = $this->fetcher->fetch($this->url, '@1553118393', false, null, null); + $result = $this->fetcher->fetch($this->url, false, null, null); $this->assertEquals([$feed, [$item]], $result); } @@ -358,7 +357,7 @@ class FeedFetcherTest extends TestCase $item = $this->createItem('video/ogg'); $feed = $this->createFeed(); $this->mockIterator($this->feed_mock, [$this->item_mock]); - $result = $this->fetcher->fetch($this->url, '@1553118393', false, null, null); + $result = $this->fetcher->fetch($this->url, false, null, null); $this->assertEquals([$feed, [$item]], $result); } @@ -373,7 +372,7 @@ class FeedFetcherTest extends TestCase $feed = $this->createFeed('de-DE'); $item = $this->createItem(); $this->mockIterator($this->feed_mock, [$this->item_mock]); - $result = $this->fetcher->fetch($this->url, '@1553118393', false, null, null); + $result = $this->fetcher->fetch($this->url, false, null, null); $this->assertEquals([$feed, [$item]], $result); } @@ -387,7 +386,7 @@ class FeedFetcherTest extends TestCase $this->createFeed('he-IL'); $this->createItem(); $this->mockIterator($this->feed_mock, [$this->item_mock]); - list($_, $items) = $this->fetcher->fetch($this->url, '@1553118393', false, null, null); + list($_, $items) = $this->fetcher->fetch($this->url, false, null, null); $this->assertTrue($items[0]->getRtl()); } @@ -413,7 +412,7 @@ class FeedFetcherTest extends TestCase $this->mockIterator($this->feed_mock, [$this->item_mock]); - list($feed, $items) = $this->fetcher->fetch($this->url, '@1553118393', false, null, null); + list($feed, $items) = $this->fetcher->fetch($this->url, false, null, null); $this->assertSame($items[0]->getPubDate(), 1522180229); } @@ -439,7 +438,7 @@ class FeedFetcherTest extends TestCase $this->mockIterator($this->feed_mock, [$this->item_mock]); - list($feed, $items) = $this->fetcher->fetch($this->url, '@1553118393', false, null, null); + list($feed, $items) = $this->fetcher->fetch($this->url, false, null, null); $this->assertSame($items[0]->getPubDate(), 1519761029); } diff --git a/tests/Unit/Fetcher/FetcherTest.php b/tests/Unit/Fetcher/FetcherTest.php index a90a2da04..157ce6905 100644 --- a/tests/Unit/Fetcher/FetcherTest.php +++ b/tests/Unit/Fetcher/FetcherTest.php @@ -54,14 +54,13 @@ class FetcherTest extends TestCase ->method('fetch') ->with( $this->equalTo($url), - $this->equalTo(true), $this->equalTo(1), $this->equalTo(2), $this->equalTo(3) ); $this->fetcher->registerFetcher($mockFetcher); - $this->fetcher->fetch($url, true, 1, 2, 3); + $this->fetcher->fetch($url, 1, 2, 3); } -- cgit v1.2.3