From 452d91ee39c72e83d69fb5c462435cc245bcff73 Mon Sep 17 00:00:00 2001 From: Bernhard Posselt Date: Fri, 22 Mar 2013 21:49:36 +0100 Subject: slim down select queries --- db/itemmapper.php | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) (limited to 'db') diff --git a/db/itemmapper.php b/db/itemmapper.php index f7d27ab23..7d0279264 100644 --- a/db/itemmapper.php +++ b/db/itemmapper.php @@ -49,15 +49,24 @@ class ItemMapper extends Mapper implements IMapper { return $items; } + + protected function makeSelectQuery($prependTo){ + return 'SELECT `*PREFIX*news_items`.* FROM `*PREFIX*news_items` ' . + 'JOIN `*PREFIX*news_feeds` ' . + 'ON `*PREFIX*news_feeds`.`id` = `*PREFIX*news_items`.`feed_id` '. + 'AND `*PREFIX*news_feeds`.`user_id` = ? ' . $prependTo; + } + + protected function makeFindAllFromFolderQuery($prependTo) { + return $this->makeSelectQuery( + 'WHERE ((`*PREFIX*news_items`.`status` & ?) > 0) ' . + $prependTo + ); + } public function find($id, $userId){ - $sql = 'SELECT `*PREFIX*news_items`.* FROM `*PREFIX*news_items` ' . - 'JOIN `*PREFIX*news_feeds` ' . - 'ON `*PREFIX*news_feeds`.`id` = `*PREFIX*news_items`.`feed_id` ' . - 'AND `*PREFIX*news_feeds`.`user_id` = ? ' . - 'WHERE `*PREFIX*news_items`.`id` = ? '; - + $sql = $this->makeSelectQuery('WHERE `*PREFIX*news_items`.`id` = ? '); $row = $this->findOneQuery($sql, array($id, $userId)); $item = new Item(); -- cgit v1.2.3