From 864794461ff14b8a049677c0e4607e3c606c5fca Mon Sep 17 00:00:00 2001
From: David Engster <deng@randomsample.de>
Date: Mon, 18 May 2020 22:00:41 +0200
Subject: Do not create spurious links in item body

The 'str_replace' will match any HTML element that starts with '<a',
including things like '<address' or '<article', thus creating spurious
links in item bodies. Fix that by simply adding one whitespace.

Fixes issue #527.

Signed-off-by: David Engster <deng@randomsample.de>
---
 lib/Db/Item.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Db/Item.php b/lib/Db/Item.php
index e88635435..3dedd308d 100644
--- a/lib/Db/Item.php
+++ b/lib/Db/Item.php
@@ -291,7 +291,7 @@ class Item extends Entity implements IAPI, \JsonSerializable
     {
         // FIXME: this should not happen if the target="_blank" is already
         // on the link
-        $body = str_replace('<a', '<a target="_blank" rel="noreferrer"', $body);
+        $body = str_replace('<a ', '<a target="_blank" rel="noreferrer" ', $body);
 
         if ($this->body !== $body) {
             $this->body = $body;
-- 
cgit v1.2.3