From 71ed9aa258cc979a8de5f33489a9bc860b687c4e Mon Sep 17 00:00:00 2001 From: Carl Schwan Date: Thu, 25 Aug 2022 09:29:17 +0200 Subject: Apply suggestions from code review Co-authored-by: anoy. Signed-off-by: Carl Schwan --- css/mobile.css | 75 ++++++++++++++++++++++------------------ css/mobile.css.map | 1 - css/mobile.scss | 48 ------------------------- src/components/AdminSettings.vue | 2 +- 4 files changed, 42 insertions(+), 84 deletions(-) delete mode 100644 css/mobile.css.map delete mode 100644 css/mobile.scss diff --git a/css/mobile.css b/css/mobile.css index d5a8a6b89..02271a263 100644 --- a/css/mobile.css +++ b/css/mobile.css @@ -1,39 +1,46 @@ -@media only screen and (max-width: 1024px) { - #app-content .utils .date { - display: none; - } - #app-shortcuts th:first-child { - padding-left: 44px; - } - #app-navigation:not(.hidden) + #app-content { - width: 100%; - } - #mark-all-read-button { - display: block; - } +@media only screen and (max-width: $breakpoint_mobile) { + #app-content .utils .date { + display: none; + } + + #app-shortcuts th:first-child { + padding-left: 44px; + } + + #app-navigation:not(.hidden) + #app-content { + width: 100%; + } + + #mark-all-read-button { + display: block; + } } + @media only screen and (max-width: 600px) { - #app-content .article-actions ul { - max-width: 164px; - } - #app-content .heading .date { - display: none; - } - #app-content .heading h1 { - margin-right: 0; - } - #app-content .utils { - padding-right: 15px; - } - #app-content .article { - padding-right: 15px; - padding-left: 44px; - } + #app-content .article-actions ul { + max-width: 164px; + } + + #app-content .heading .date { + display: none; + } + + #app-content .heading h1 { + margin-right: 0; + } + + #app-content .utils { + padding-right: 15px; + } + + #app-content .article { + padding-right: 15px; + padding-left: 44px; + } } + @media only screen and (max-width: 340px) { - #app-content .article-actions { - max-width: 82px; - } + #app-content .article-actions { + max-width: 82px; + } } - -/*# sourceMappingURL=mobile.css.map */ diff --git a/css/mobile.css.map b/css/mobile.css.map deleted file mode 100644 index 24468a1a6..000000000 --- a/css/mobile.css.map +++ /dev/null @@ -1 +0,0 @@ -{"version":3,"sourceRoot":"","sources":["mobile.scss"],"names":[],"mappings":"AAEA;EACI;IACI;;EAGJ;IACI;;EAGJ;IACI;;EAGJ;IACI;;;AAIR;EACI;IACI;;EAGJ;IACI;;EAGJ;IACI;;EAGJ;IACI;;EAGJ;IACI;IACA;;;AAIR;EACI;IACI","file":"mobile.css"} \ No newline at end of file diff --git a/css/mobile.scss b/css/mobile.scss deleted file mode 100644 index eb0c7e9f0..000000000 --- a/css/mobile.scss +++ /dev/null @@ -1,48 +0,0 @@ -$breakpoint-mobile: 1024px; - -@media only screen and (max-width: 1024px) { - #app-content .utils .date { - display: none; - } - - #app-shortcuts th:first-child { - padding-left: 44px; - } - - #app-navigation:not(.hidden) + #app-content { - width: 100%; - } - - #mark-all-read-button { - display: block; - } -} - -@media only screen and (max-width: 600px) { - #app-content .article-actions ul { - max-width: 164px; - } - - #app-content .heading .date { - display: none; - } - - #app-content .heading h1 { - margin-right: 0; - } - - #app-content .utils { - padding-right: 15px; - } - - #app-content .article { - padding-right: 15px; - padding-left: 44px; - } -} - -@media only screen and (max-width: 340px) { - #app-content .article-actions { - max-width: 82px; - } -} diff --git a/src/components/AdminSettings.vue b/src/components/AdminSettings.vue index 460417449..d3496ffdd 100644 --- a/src/components/AdminSettings.vue +++ b/src/components/AdminSettings.vue @@ -114,7 +114,7 @@ export default { } -