From 137af71bb3578b46937d5cb0db363d7674861fc4 Mon Sep 17 00:00:00 2001
From: Benjamin Brahmer <info@b-brahmer.de>
Date: Sun, 17 Oct 2021 15:16:25 +0200
Subject: Smarter error logging

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
---
 lib/Fetcher/FeedFetcher.php | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/lib/Fetcher/FeedFetcher.php b/lib/Fetcher/FeedFetcher.php
index 7d8255e37..7423c66df 100755
--- a/lib/Fetcher/FeedFetcher.php
+++ b/lib/Fetcher/FeedFetcher.php
@@ -377,22 +377,13 @@ class FeedFetcher implements IFeedFetcher
                 ]
             );
         } catch (RequestException $e) {
-            if ($e->hasResponse()) {
                 $this->logger->info(
                     'An error occurred while trying to download the feed logo of {url}: {error}',
                     [
                     'url'   => $url,
-                    'error' => $e->getResponse()
+                    'error' => $e->getResponse() ?? 'Unknown'
                     ]
                 );
-            } else {
-                $this->logger->info(
-                    'An unknown error occurred while trying to download the feed logo of {url}.',
-                    [
-                    'url' => $url,
-                    ]
-                );
-            }
         }
 
         $is_image = $downloaded && substr(mime_content_type($favicon_path), 0, 5) === "image";
-- 
cgit v1.2.3