diff options
| -rw-r--r-- | tests/unit/utility/articleenhancer/ArticleEnhancerTest.php | 8 | ||||
| -rw-r--r-- | utility/articleenhancer/articleenhancer.php | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/tests/unit/utility/articleenhancer/ArticleEnhancerTest.php b/tests/unit/utility/articleenhancer/ArticleEnhancerTest.php index ce105db49..f252c4fac 100644 --- a/tests/unit/utility/articleenhancer/ArticleEnhancerTest.php +++ b/tests/unit/utility/articleenhancer/ArticleEnhancerTest.php @@ -246,7 +246,7 @@ class ArticleEnhancerTest extends \OCA\AppFramework\Utility\TestUtility { $file->headers = array("content-type"=>"text/html; charset=utf-8"); $file->body = '<html> <body> - <img src="relative/url.png"> + <img src="relative/url.png?a=1&b=2"> </body> </html>'; $item = new Item(); @@ -260,11 +260,11 @@ class ArticleEnhancerTest extends \OCA\AppFramework\Utility\TestUtility { ->will($this->returnValue($file)); $this->purifier->expects($this->once()) ->method('purify') - ->with($this->equalTo('<img src="https://username:secret@www.explosm.net/all/relative/url.png">')) - ->will($this->returnValue('<img src="https://username:secret@www.explosm.net/all/relative/url.png">')); + ->with($this->equalTo('<img src="https://username:secret@www.explosm.net/all/relative/url.png?a=1&b=2">')) + ->will($this->returnValue('<img src="https://username:secret@www.explosm.net/all/relative/url.png?a=1&b=2">')); $result = $this->testEnhancer->enhance($item); - $this->assertEquals('<img src="https://username:secret@www.explosm.net/all/relative/url.png">', $result->getBody()); + $this->assertEquals('<img src="https://username:secret@www.explosm.net/all/relative/url.png?a=1&b=2">', $result->getBody()); } public function testDontTransformAbsoluteUrlsAndMails() { diff --git a/utility/articleenhancer/articleenhancer.php b/utility/articleenhancer/articleenhancer.php index 823ddcc18..6450f638d 100644 --- a/utility/articleenhancer/articleenhancer.php +++ b/utility/articleenhancer/articleenhancer.php @@ -121,7 +121,7 @@ abstract class ArticleEnhancer { $xpathResult = $xpath->query("//*[@".$attribute." and not(contains(@".$attribute.", '://')) and not(starts-with(@".$attribute.", 'mailto:'))]"); foreach ($xpathResult as $linkNode) { $urlElement = $linkNode->attributes->getNamedItem($attribute); - $urlElement->nodeValue = $this->relativeToAbsoluteUrl( $urlElement->nodeValue, $absoluteUrl ); + $urlElement->nodeValue = htmlentities( $this->relativeToAbsoluteUrl( $urlElement->nodeValue, $absoluteUrl ) ); } } |