diff options
author | Daniel Opitz <git@copynpaste.de> | 2018-10-16 22:37:48 +0200 |
---|---|---|
committer | Sean Molenaar <SMillerDev@users.noreply.github.com> | 2018-12-04 17:10:46 +0100 |
commit | e158cc1d3b1fb33de5aaa1aaac0c7828016fb7b9 (patch) | |
tree | 4d3b4da643a428f259ca9fe1c63d97f8cecfb5fc /tests/Unit/Fetcher | |
parent | 5c7fdb08534018ba86ec4a38f45b63cbbf67a72f (diff) |
use magic class constant instead of classname strings
Diffstat (limited to 'tests/Unit/Fetcher')
-rw-r--r-- | tests/Unit/Fetcher/FeedFetcherTest.php | 45 | ||||
-rw-r--r-- | tests/Unit/Fetcher/FetcherTest.php | 15 | ||||
-rw-r--r-- | tests/Unit/Fetcher/YoutubeFetcherTest.php | 5 |
3 files changed, 27 insertions, 38 deletions
diff --git a/tests/Unit/Fetcher/FeedFetcherTest.php b/tests/Unit/Fetcher/FeedFetcherTest.php index 50fd4d6d6..36eaefa1e 100644 --- a/tests/Unit/Fetcher/FeedFetcherTest.php +++ b/tests/Unit/Fetcher/FeedFetcherTest.php @@ -16,9 +16,16 @@ namespace OCA\News\Tests\Unit\Fetcher; use \OCA\News\Db\Item; use \OCA\News\Db\Feed; use OCA\News\Fetcher\FeedFetcher; +use OCA\News\Utility\PicoFeedFaviconFactory; +use OCA\News\Utility\Time; use OCP\Http\Client\IClientService; -use PicoFeed\Processor\ItemPostProcessor; +use OCP\IL10N; use PHPUnit\Framework\TestCase; +use PicoFeed\Client\Client; +use PicoFeed\Parser\Parser; +use PicoFeed\Processor\ItemPostProcessor; +use PicoFeed\Reader\Favicon; +use PicoFeed\Reader\Reader; class FeedFetcherTest extends TestCase @@ -62,51 +69,33 @@ class FeedFetcherTest extends TestCase protected function setUp() { - $this->l10n = $this->getMockBuilder( - '\OCP\IL10N' - ) + $this->l10n = $this->getMockBuilder(IL10N::class) ->disableOriginalConstructor() ->getMock(); - $this->reader = $this->getMockBuilder( - '\PicoFeed\Reader\Reader' - ) + $this->reader = $this->getMockBuilder(Reader::class) ->disableOriginalConstructor() ->getMock(); - $this->parser = $this->getMockBuilder( - '\PicoFeed\Parser\Parser' - ) + $this->parser = $this->getMockBuilder(Parser::class) ->disableOriginalConstructor() ->getMock(); - $this->client = $this->getMockBuilder( - '\PicoFeed\Client\Client' - ) + $this->client = $this->getMockBuilder(Client::class) ->disableOriginalConstructor() ->getMock(); - $this->parsedFeed = $this->getMockBuilder( - '\PicoFeed\Parser\Feed' - ) + $this->parsedFeed = $this->getMockBuilder(\PicoFeed\Parser\Feed::class) ->disableOriginalConstructor() ->getMock(); - $this->item = $this->getMockBuilder( - '\PicoFeed\Parser\Item' - ) + $this->item = $this->getMockBuilder(\PicoFeed\Parser\Item::class) ->disableOriginalConstructor() ->getMock(); - $this->faviconFetcher = $this->getMockBuilder( - '\PicoFeed\Reader\Favicon' - ) + $this->faviconFetcher = $this->getMockBuilder(Favicon::class) ->disableOriginalConstructor() ->getMock(); - $this->faviconFactory = $this->getMockBuilder( - '\OCA\News\Utility\PicoFeedFaviconFactory' - ) + $this->faviconFactory = $this->getMockBuilder(PicoFeedFaviconFactory::class) ->disableOriginalConstructor() ->getMock(); $this->time = 2323; - $timeFactory = $this->getMockBuilder( - '\OCA\News\Utility\Time' - ) + $timeFactory = $this->getMockBuilder(Time::class) ->disableOriginalConstructor() ->getMock(); $timeFactory->expects($this->any()) diff --git a/tests/Unit/Fetcher/FetcherTest.php b/tests/Unit/Fetcher/FetcherTest.php index 5ff800b21..e8c648177 100644 --- a/tests/Unit/Fetcher/FetcherTest.php +++ b/tests/Unit/Fetcher/FetcherTest.php @@ -26,6 +26,7 @@ namespace OCA\News\Tests\Unit\Fetcher; use OCA\News\Fetcher\Fetcher; +use OCA\News\Fetcher\IFeedFetcher; use PHPUnit\Framework\TestCase; class FetcherTest extends TestCase @@ -42,7 +43,7 @@ class FetcherTest extends TestCase public function testFetch() { $url = 'hi'; - $mockFetcher = $this->getMockBuilder('\OCA\News\Fetcher\IFeedFetcher') + $mockFetcher = $this->getMockBuilder(IFeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $mockFetcher->expects($this->once()) @@ -67,14 +68,14 @@ class FetcherTest extends TestCase public function testNoFetchers() { $url = 'hi'; - $mockFetcher = $this->getMockBuilder('\OCA\News\Fetcher\IFeedFetcher') + $mockFetcher = $this->getMockBuilder(IFeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $mockFetcher->expects($this->once()) ->method('canHandle') ->with($this->equalTo($url)) ->will($this->returnValue(false)); - $mockFetcher2 = $this->getMockBuilder('\OCA\News\Fetcher\IFeedFetcher') + $mockFetcher2 = $this->getMockBuilder(IFeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $mockFetcher2->expects($this->once()) @@ -92,14 +93,14 @@ class FetcherTest extends TestCase public function testMultipleFetchers() { $url = 'hi'; - $mockFetcher = $this->getMockBuilder('\OCA\News\Fetcher\IFeedFetcher') + $mockFetcher = $this->getMockBuilder(IFeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $mockFetcher->expects($this->once()) ->method('canHandle') ->with($this->equalTo($url)) ->will($this->returnValue(false)); - $mockFetcher2 = $this->getMockBuilder('\OCA\News\Fetcher\IFeedFetcher') + $mockFetcher2 = $this->getMockBuilder(IFeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $mockFetcher2->expects($this->once()) @@ -118,7 +119,7 @@ class FetcherTest extends TestCase { $url = 'hi'; $return = 'zeas'; - $mockFetcher = $this->getMockBuilder('\OCA\News\Fetcher\IFeedFetcher') + $mockFetcher = $this->getMockBuilder(IFeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $mockFetcher->expects($this->once()) @@ -129,7 +130,7 @@ class FetcherTest extends TestCase ->method('fetch') ->with($this->equalTo($url)) ->will($this->returnValue($return)); - $mockFetcher2 = $this->getMockBuilder('\OCA\News\Fetcher\IFeedFetcher') + $mockFetcher2 = $this->getMockBuilder(IFeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $mockFetcher2->expects($this->never()) diff --git a/tests/Unit/Fetcher/YoutubeFetcherTest.php b/tests/Unit/Fetcher/YoutubeFetcherTest.php index fbfd04c02..f53958b8f 100644 --- a/tests/Unit/Fetcher/YoutubeFetcherTest.php +++ b/tests/Unit/Fetcher/YoutubeFetcherTest.php @@ -12,6 +12,7 @@ namespace OCA\News\Tests\Unit\Fetcher; use \OCA\News\Db\Feed; +use OCA\News\Fetcher\FeedFetcher; use OCA\News\Fetcher\YoutubeFetcher; use PHPUnit\Framework\TestCase; @@ -24,9 +25,7 @@ class YoutubeFetcherTest extends TestCase public function setUp() { - $this->feedFetcher = $this->getMockBuilder( - '\OCA\News\Fetcher\FeedFetcher' - ) + $this->feedFetcher = $this->getMockBuilder(FeedFetcher::class) ->disableOriginalConstructor() ->getMock(); $this->fetcher = new YoutubeFetcher($this->feedFetcher); |