diff options
author | Daniel Opitz <git@copynpaste.de> | 2018-10-16 22:37:48 +0200 |
---|---|---|
committer | Sean Molenaar <SMillerDev@users.noreply.github.com> | 2018-12-04 17:10:46 +0100 |
commit | e158cc1d3b1fb33de5aaa1aaac0c7828016fb7b9 (patch) | |
tree | 4d3b4da643a428f259ca9fe1c63d97f8cecfb5fc /tests/Unit/Config | |
parent | 5c7fdb08534018ba86ec4a38f45b63cbbf67a72f (diff) |
use magic class constant instead of classname strings
Diffstat (limited to 'tests/Unit/Config')
-rw-r--r-- | tests/Unit/Config/ConfigTest.php | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/tests/Unit/Config/ConfigTest.php b/tests/Unit/Config/ConfigTest.php index 36e800ba4..992453cca 100644 --- a/tests/Unit/Config/ConfigTest.php +++ b/tests/Unit/Config/ConfigTest.php @@ -14,6 +14,9 @@ namespace OCA\News\Tests\Unit\Config; use OCA\News\Config\Config; +use OCP\Files\File; +use OCP\Files\Folder; +use OCP\ILogger; use PHPUnit\Framework\TestCase; class ConfigTest extends TestCase @@ -26,12 +29,10 @@ class ConfigTest extends TestCase public function setUp() { - $this->logger = $this->getMockBuilder( - 'OCP\ILogger' - ) + $this->logger = $this->getMockBuilder(ILogger::class) ->disableOriginalConstructor() ->getMock(); - $this->fileSystem = $this->getMockBuilder('OCP\Files\Folder')->getMock(); + $this->fileSystem = $this->getMockBuilder(Folder::class)->getMock(); $this->loggerParams = ['hi']; $this->config = new Config( $this->fileSystem, $this->logger, $this->loggerParams @@ -54,7 +55,7 @@ class ConfigTest extends TestCase public function testRead() { - $file = $this->getMockBuilder('OCP\Files\File')->getMock(); + $file = $this->getMockBuilder(File::class)->getMock(); $this->fileSystem->expects($this->once()) ->method('get') ->with($this->equalTo($this->configPath)) @@ -77,7 +78,7 @@ class ConfigTest extends TestCase public function testReadIgnoresVeryLowPurgeInterval() { - $file = $this->getMockBuilder('OCP\Files\File')->getMock(); + $file = $this->getMockBuilder(File::class)->getMock(); $this->fileSystem->expects($this->once()) ->method('get') ->with($this->equalTo($this->configPath)) @@ -95,7 +96,7 @@ class ConfigTest extends TestCase public function testReadBool() { - $file = $this->getMockBuilder('OCP\Files\File')->getMock(); + $file = $this->getMockBuilder(File::class)->getMock(); $this->fileSystem->expects($this->once()) ->method('get') ->with($this->equalTo($this->configPath)) @@ -117,7 +118,7 @@ class ConfigTest extends TestCase public function testReadLogsInvalidValue() { - $file = $this->getMockBuilder('OCP\Files\File')->getMock(); + $file = $this->getMockBuilder(File::class)->getMock(); $this->fileSystem->expects($this->once()) ->method('get') ->with($this->equalTo($this->configPath)) @@ -141,7 +142,7 @@ class ConfigTest extends TestCase public function testReadLogsInvalidINI() { - $file = $this->getMockBuilder('OCP\Files\File')->getMock(); + $file = $this->getMockBuilder(File::class)->getMock(); $this->fileSystem->expects($this->once()) ->method('get') ->with($this->equalTo($this->configPath)) @@ -173,7 +174,7 @@ class ConfigTest extends TestCase $this->config->setMaxSize(399); $this->config->setExploreUrl('http://google.de'); - $file = $this->getMockBuilder('OCP\Files\File')->getMock(); + $file = $this->getMockBuilder(File::class)->getMock(); $this->fileSystem->expects($this->once()) ->method('get') ->with($this->equalTo($this->configPath)) @@ -207,7 +208,7 @@ class ConfigTest extends TestCase $this->fileSystem->expects($this->once()) ->method('newFile') ->with($this->equalTo($this->configPath)); - $file = $this->getMockBuilder('OCP\Files\File')->getMock(); + $file = $this->getMockBuilder(File::class)->getMock(); $this->fileSystem->expects($this->once()) ->method('get') ->with($this->equalTo($this->configPath)) |