Split binary to booleans (#203)

* replaced old status with 2 flags for unread and starred

* add fields to db, replace int(1,0) with booleans in sql queries, removed StatusFlags class + refactor code relying to it

* add repair step for migration

* again use integer(1,0) instead of bool in sql queries, because of sqlite doesn't support true/false

* add/fix unit tests for new boolean status

* set unread/starred flags as statements in sql

* fixed mysql unknown column items.unread, fixed marking of read items on repair step

* remove unnecessary bool casts

* add empty checks to Items::is* methods

* update migration to use native sql instead of the querybuilder

* don't cast the flags manually, let the api do the work

1 files changed, 5 insertions, 8 deletions

diff --git a/tests/Integration/Db/ItemMapperTest.php b/tests/Integration/Db/ItemMapperTest.php
index 6b621e070..fa9cc7d25 100644
--- a/tests/Integration/Db/ItemMapperTest.php
+++ b/tests/Integration/Db/ItemMapperTest.php
@@ -112,9 +112,8 @@ class ItemMapperTest extends IntegrationTest {
 
         $this->itemMapper->readAll(PHP_INT_MAX, 10, $this->user);
 
-        $status = StatusFlag::UNREAD;
         $items = $this->itemMapper->findAll(
-            30, 0, $status, false, $this->user
+            30, 0, 0, false, false, $this->user
         );
 
         $this->assertEquals(0, count($items));
@@ -144,9 +143,8 @@ class ItemMapperTest extends IntegrationTest {
             $folderId, PHP_INT_MAX, 10, $this->user
         );
 
-        $status = StatusFlag::UNREAD;
         $items = $this->itemMapper->findAll(
-            30, 0, $status, false, $this->user
+            30, 0, 0, false, false, $this->user
         );
 
         $this->assertEquals(1, count($items));
@@ -176,9 +174,8 @@ class ItemMapperTest extends IntegrationTest {
             $feedId, PHP_INT_MAX, 10, $this->user
         );
 
-        $status = StatusFlag::UNREAD;
         $items = $this->itemMapper->findAll(
-            30, 0, $status, false, $this->user
+            30, 0, 0, false, false, $this->user
         );
 
         $this->assertEquals(2, count($items));
@@ -246,7 +243,7 @@ class ItemMapperTest extends IntegrationTest {
         // assert that all test user's same items are read
         $items = $this->itemMapper->where(['feedId' => $feed->getId(), 'title' => 'blubb']);
         foreach ($items as $item) {
-            $this->assertTrue($item->isRead());
+            $this->assertFalse($item->isUnread());
         }
 
         // assert that a different item is not read
@@ -277,7 +274,7 @@ class ItemMapperTest extends IntegrationTest {
             if ($item->getId() === $duplicateItem->getId()) {
                 $this->assertTrue($item->isUnread());
             } else {
-                $this->assertTrue($item->isRead());
+                $this->assertFalse($item->isUnread());
             }
         }